✨ Create operator CRs based on helm values#191
Merged
Conversation
Contributor
|
/assign |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
furkatgofurov7
left a comment
Member
There was a problem hiding this comment.
Great addition, thanks for working on this!
Only one small nit:
Comment on lines
+97
to
+99
| ```bash | ||
| helm install capi-operator capi-operator/cluster-api-operator --create-namespace -n capi-operator-system —set infrastructure=docker,azure --wait # core Cluster API with kubeadm bootstrap and control plane providers will also be installed | ||
| ``` |
Member
There was a problem hiding this comment.
this is a duplicate of lines 93-95
Contributor
|
LGTM label has been added. DetailsGit tree hash: 71767bdcb1affb1d00b649d02cff016be4bfe7cb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR improves the quickstart installation process by adding a similar to
clusterctl initfunctionality based on helm:helm install capi-operator capi-operator/cluster-api-operator --create-namespace -n capi-operator-system --set infrastructure=docker:v1.4.2 --wait # core Cluster API with kubeadm bootstrap and control plane providers will also be installedhelm install capi-operator capi-operator/cluster-api-operator --create-namespace -n capi-operator-system —set infrastructure=docker,azure --wait # core Cluster API with kubeadm bootstrap and control plane providers will also be installedhelm install capi-operator capi-operator/cluster-api-operator --create-namespace -n capi-operator-system —set infrastructure=docker,azure --wait # core Cluster API with kubeadm bootstrap and control plane providers will also be installedI also added some tests to verify that we don't break it in the future. These tests will be a part of e2e suite and require a new kind cluster because helm validates against a running cluster and having one cluster will cause problems.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #130