Conversation
💡 Codex Reviewcodex/codex-rs/tui/src/app_server_session.rs Lines 1414 to 1417 in 9c17b2d When ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
Why
TurnContextItemis persisted into rollout history and is the durable turn baseline used for resume, fork, and compaction reconstruction. New writers already recordpermission_profile, but the public type still exposed legacysandbox_policyandfile_system_sandbox_policyfields, forcing callers and tests to keep filling legacy compatibility slots even though the canonical data is available.This PR makes the serialized shape canonical for new rollout writes while preserving reads of old rollout files.
What Changed
TurnContextItem.permission_profilefromOption<PermissionProfile>to requiredPermissionProfile.sandbox_policyandfile_system_sandbox_policyfields fromTurnContextItem.DeserializeforTurnContextItemthat still accepts old rollout JSON containingsandbox_policyand optionalfile_system_sandbox_policy, immediately projecting that legacy data intoPermissionProfile.Verification
cargo check -p codex-protocol -p codex-core -p codex-tui -p codex-state -p codex-rollout --testscargo test -p codex-protocol turn_context_item_cargo test -p codex-core turn_context_item_Stack created with Sapling. Best reviewed with ReviewStack.