Conversation
This was referenced Apr 30, 2026
This was referenced Apr 30, 2026
This was referenced Apr 30, 2026
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Unix sandbox integration tests were still parameterized by
SandboxPolicyand converted each fixture intoPermissionProfileimmediately before launching the sandboxed command. These tests exercise the runtime sandbox launch paths, not the legacy policy bridge, so they should construct the canonical profile shape directly.What Changed
PermissionProfiledirectly.PermissionProfile::read_only().PermissionProfile::workspace_write_with(...), preserving the existing writable roots, restricted network, and tmpdir exclusion knobs.SandboxPolicyimport fromexec/tests/suite/sandbox.rs.Verification
cargo test -p codex-exec allow_unix_socketpair_recvfrom -- --nocaptureStack created with Sapling. Best reviewed with ReviewStack.