Conversation
This was referenced Apr 30, 2026
This was referenced Apr 30, 2026
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The approvals integration matrix was still modeling each scenario with
SandboxPolicy, then applying that legacy policy to config and turns. That made the tests less representative of the new permission-profile path and kept the largest non-boundarySandboxPolicycluster alive incore/tests.This PR keeps the same approval scenarios and expected behavior, but seeds them from
PermissionProfileinstead.What Changed
ScenarioSpecnow stores aPermissionProfilerather than aSandboxPolicy.config.permissions.set_permission_profile(...)instead of the legacy sandbox setter.Op::UserTurn.sandbox_policycompatibility field from the profile viaturn_permission_fields(...), while also sending the profile.core/tests/suite/approvals.rsnow usePermissionProfile::Disabled,PermissionProfile::read_only(), orPermissionProfile::workspace_write_with(...)directly.rg '\bSandboxPolicy\b' codex-rs/core/tests/suite/approvals.rsno longer matches anything.Verification
cargo test -p codex-core --test all approvals --no-runStack created with Sapling. Best reviewed with ReviewStack.