Conversation
This was referenced Apr 30, 2026
This was referenced Apr 30, 2026
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The app-server v2 turn API now has a named permissions selection path. Several integration tests were still changing turn permissions through the legacy
sandboxPolicyrequest field, which keeps coverage biased toward the old abstraction even when the scenario is not testing legacy compatibility.What Changed
permissions: { type: "profile", id: ... }for:workspaceand:danger-no-sandboxoverrides.SandboxPolicyreferences fromturn_start.rsandturn_start_zsh_fork.rs; the remaining v2 app-server test reference intentionally verifies thatcommand/execrejectssandboxPolicycombined withpermissionProfile.Verification
cargo test -p codex-app-server --test all turn_start_rejects_invalid_permission_selection_before_starting_turn -- --nocapturecargo test -p codex-app-server --test all turn_start_updates_permissions_and_cwd_between_turns_v2 -- --nocapturejust fix -p codex-app-serverStack created with Sapling. Best reviewed with ReviewStack.