feat: use new resource repo bindings for oci#1718
Merged
matthiasbruns merged 4 commits intoFeb 4, 2026
Merged
Conversation
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
fabianburth
approved these changes
Feb 4, 2026
piotrjanik
approved these changes
Feb 4, 2026
This was referenced Feb 4, 2026
matthiasbruns
added a commit
that referenced
this pull request
Feb 5, 2026
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Follow up from #1718 We forgot to add ```go UploadResource(ctx context.Context, res *descriptor.Resource, content blob.ReadOnlyBlob, credentials map[string]string) (*descriptor.Resource, error) ``` to the `bindings/go/oci/repository/resource/resource_repository.go` implementation. #### Which issue(s) this PR fixes Contributes: open-component-model/ocm-project#796 --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
Merged
matthiasbruns
added a commit
that referenced
this pull request
Feb 13, 2026
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it This PR ties all the changes related to open-component-model/ocm-project#796 together in the cli package and implement oci transfer with tests. It also adds two new flags, which were taken from old ocm https://ocm.software/docs/reference/ocm-cli/transfer/componentversions/ - `FlagCopyResources = "copy-resources"` in addition, I've added an integration test, that: - creates two oci registries - uploads one artifact to the first registry - creates a cv pointing to the artifact - calls: ```go transferCMD.SetArgs([]string{ "transfer", "component-version", sourceRef, targetRef, "--config", cfgPath, "--copy-resources", // required, otherwise we wouldn't transfer oci artifacts }) ``` - verifies, that the oci artifact is in the 2nd registry #### Which issue(s) this PR fixes Contributes: open-component-model/ocm-project#796 Split PRs: - #1730 - #1751 - #1736 - #1727 - #1718 - #1717 --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com> Signed-off-by: Matthias Bruns <github@matthiasbruns.com> Signed-off-by: Fabian Burth <fabian.burth@sap.com> Co-authored-by: Fabian Burth <fabian.burth@sap.com>
morri-son
pushed a commit
to morri-son/open-component-model
that referenced
this pull request
Feb 16, 2026
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it This PR ties all the changes related to open-component-model/ocm-project#796 together in the cli package and implement oci transfer with tests. It also adds two new flags, which were taken from old ocm https://ocm.software/docs/reference/ocm-cli/transfer/componentversions/ - `FlagCopyResources = "copy-resources"` in addition, I've added an integration test, that: - creates two oci registries - uploads one artifact to the first registry - creates a cv pointing to the artifact - calls: ```go transferCMD.SetArgs([]string{ "transfer", "component-version", sourceRef, targetRef, "--config", cfgPath, "--copy-resources", // required, otherwise we wouldn't transfer oci artifacts }) ``` - verifies, that the oci artifact is in the 2nd registry #### Which issue(s) this PR fixes Contributes: open-component-model/ocm-project#796 Split PRs: - open-component-model#1730 - open-component-model#1751 - open-component-model#1736 - open-component-model#1727 - open-component-model#1718 - open-component-model#1717 --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com> Signed-off-by: Matthias Bruns <github@matthiasbruns.com> Signed-off-by: Fabian Burth <fabian.burth@sap.com> Co-authored-by: Fabian Burth <fabian.burth@sap.com>
morri-son
pushed a commit
to morri-son/open-component-model
that referenced
this pull request
Feb 18, 2026
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it This PR ties all the changes related to open-component-model/ocm-project#796 together in the cli package and implement oci transfer with tests. It also adds two new flags, which were taken from old ocm https://ocm.software/docs/reference/ocm-cli/transfer/componentversions/ - `FlagCopyResources = "copy-resources"` in addition, I've added an integration test, that: - creates two oci registries - uploads one artifact to the first registry - creates a cv pointing to the artifact - calls: ```go transferCMD.SetArgs([]string{ "transfer", "component-version", sourceRef, targetRef, "--config", cfgPath, "--copy-resources", // required, otherwise we wouldn't transfer oci artifacts }) ``` - verifies, that the oci artifact is in the 2nd registry #### Which issue(s) this PR fixes Contributes: open-component-model/ocm-project#796 Split PRs: - open-component-model#1730 - open-component-model#1751 - open-component-model#1736 - open-component-model#1727 - open-component-model#1718 - open-component-model#1717 --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com> Signed-off-by: Matthias Bruns <github@matthiasbruns.com> Signed-off-by: Fabian Burth <fabian.burth@sap.com> Co-authored-by: Fabian Burth <fabian.burth@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1715
This PR updates the cli and controller module.
What this PR does / why we need it
In ociArtifact PR we need the oci.Repository or something comparable to get oci artifacts in the transformation. We had no real way to provide a credentials-based oci repository since now.
This PR updates the
ResourceRepositoryinbindings/go/repository/interface.goto make it credential-aware.Since we did not want to change the implementation of the
ocirepository, we opted for a wrapper comparable to the one incli/internal/plugin/builtin/oci(now deleted). The wrapper was moved intobindings/go/oci/repository/resource.cliandcontrollerswere updated as well to register the newResourceRepository.Which issue(s) this PR fixes
Contributes open-component-model/ocm-project#796