feat: refactor resource repository and fix usage in cli and controller#1715
Closed
matthiasbruns wants to merge 2 commits into
Closed
feat: refactor resource repository and fix usage in cli and controller#1715matthiasbruns wants to merge 2 commits into
matthiasbruns wants to merge 2 commits into
Conversation
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
Merged
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
This was referenced Feb 4, 2026
matthiasbruns
added a commit
that referenced
this pull request
Feb 4, 2026
Part of #1715 This PR updates the oci module. #### What this PR does / why we need it In [ociArtifact PR](https://github.com/open-component-model/open-component-model/pull/1683/changes#diff-a3d391171fbdcde50e7d94ee010485559a0d10eb1149526e04bc46cc4546eadeR196) we need the oci.Repository or something comparable to get oci artifacts in the transformation. We had no real way to provide a credentials-based oci repository since now. This PR updates the `ResourceRepository` in `bindings/go/repository/interface.go` to make it credential-aware. Since we did not want to change the implementation of the `oci` repository, we opted for a wrapper comparable to the one in `cli/internal/plugin/builtin/oci` (now deleted). The wrapper was moved into `bindings/go/oci/repository/resource`. `cli` and `controllers` were updated as well to register the new `ResourceRepository`. #### Which issue(s) this PR fixes Contributes open-component-model/ocm-project#796 --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
matthiasbruns
added a commit
that referenced
this pull request
Feb 4, 2026
…ls (#1716) Part of #1715 This PR updates the repository interface. #### What this PR does / why we need it In [ociArtifact PR](https://github.com/open-component-model/open-component-model/pull/1683/changes#diff-a3d391171fbdcde50e7d94ee010485559a0d10eb1149526e04bc46cc4546eadeR196) we need the oci.Repository or something comparable to get oci artifacts in the transformation. We had no real way to provide a credentials-based oci repository since now. This PR updates the `ResourceRepository` in `bindings/go/repository/interface.go` to make it credential-aware. Since we did not want to change the implementation of the `oci` repository, we opted for a wrapper comparable to the one in `cli/internal/plugin/builtin/oci` (now deleted). The wrapper was moved into `bindings/go/oci/repository/resource`. `cli` and `controllers` were updated as well to register the new `ResourceRepository`. #### Which issue(s) this PR fixes Contributes open-component-model/ocm-project#796 --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com> Signed-off-by: Matthias Bruns <github@matthiasbruns.com> Co-authored-by: Fabian Burth <fabian.burth@sap.com>
matthiasbruns
added a commit
that referenced
this pull request
Feb 4, 2026
Part of #1715 This PR updates the cli and controller module. #### What this PR does / why we need it In [ociArtifact PR](https://github.com/open-component-model/open-component-model/pull/1683/changes#diff-a3d391171fbdcde50e7d94ee010485559a0d10eb1149526e04bc46cc4546eadeR196) we need the oci.Repository or something comparable to get oci artifacts in the transformation. We had no real way to provide a credentials-based oci repository since now. This PR updates the `ResourceRepository` in `bindings/go/repository/interface.go` to make it credential-aware. Since we did not want to change the implementation of the `oci` repository, we opted for a wrapper comparable to the one in `cli/internal/plugin/builtin/oci` (now deleted). The wrapper was moved into `bindings/go/oci/repository/resource`. `cli` and `controllers` were updated as well to register the new `ResourceRepository`. #### Which issue(s) this PR fixes Contributes open-component-model/ocm-project#796 --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
Contributor
Author
|
merged in #1718 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
In ociArtifact PR we need the oci.Repository or something comparable to get oci artifacts in the transformation. We had no real way to provide a credentials-based oci repository since now.
This PR updates the
ResourceRepositoryinbindings/go/repository/interface.goto make it credential-aware.Since we did not want to change the implementation of the
ocirepository, we opted for a wrapper comparable to the one incli/internal/plugin/builtin/oci(now deleted). The wrapper was moved intobindings/go/oci/repository/resource.cliandcontrollerswere updated as well to register the newResourceRepository.Which issue(s) this PR fixes
Contributes open-component-model/ocm-project#796
Split PRs