feat!: BREAKING CHANGE: update ResourceRepository to require credentials#1716
Merged
matthiasbruns merged 5 commits intoFeb 4, 2026
Conversation
…a param On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
fabianburth
reviewed
Feb 4, 2026
Co-authored-by: Fabian Burth <fabian.burth@sap.com> Signed-off-by: Matthias Bruns <github@matthiasbruns.com>
fabianburth
previously approved these changes
Feb 4, 2026
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
jakobmoellerdev
approved these changes
Feb 4, 2026
Skarlso
approved these changes
Feb 4, 2026
fabianburth
approved these changes
Feb 4, 2026
345bf4d
into
open-component-model:main
23 of 24 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1715
This PR updates the repository interface.
What this PR does / why we need it
In ociArtifact PR we need the oci.Repository or something comparable to get oci artifacts in the transformation. We had no real way to provide a credentials-based oci repository since now.
This PR updates the
ResourceRepositoryinbindings/go/repository/interface.goto make it credential-aware.Since we did not want to change the implementation of the
ocirepository, we opted for a wrapper comparable to the one incli/internal/plugin/builtin/oci(now deleted). The wrapper was moved intobindings/go/oci/repository/resource.cliandcontrollerswere updated as well to register the newResourceRepository.Which issue(s) this PR fixes
Contributes open-component-model/ocm-project#796