feat: oci artifact cli by matthiasbruns · Pull Request #1684 · open-component-model/open-component-model

matthiasbruns · 2026-01-30T11:19:18Z

What this PR does / why we need it

This PR ties all the changes related to open-component-model/ocm-project#796 together in the cli package and implement oci transfer with tests.
It also adds two new flags, which were taken from old ocm https://ocm.software/docs/reference/ocm-cli/transfer/componentversions/

FlagCopyResources = "copy-resources"

in addition, I've added an integration test, that:

creates two oci registries
uploads one artifact to the first registry
creates a cv pointing to the artifact
calls:

transferCMD.SetArgs([]string{
		"transfer",
		"component-version",
		sourceRef,
		targetRef,
		"--config", cfgPath,
		"--copy-resources", // required, otherwise we wouldn't transfer oci artifacts
	})

verifies, that the oci artifact is in the 2nd registry

Which issue(s) this PR fixes

Contributes: open-component-model/ocm-project#796

Split PRs:

jakobmoellerdev

generally LGTM, nice stuff. just minor questions and clarifications for testing and usage

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

Signed-off-by: Matthias Bruns <github@matthiasbruns.com>

Signed-off-by: Fabian Burth <fabian.burth@sap.com>

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> # Conflicts: # cli/go.mod # cli/go.sum # cli/integration/go.mod # cli/integration/go.sum

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> # Conflicts: # cli/go.mod # cli/go.sum # cli/integration/go.sum

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

#### What this PR does / why we need it This PR is the result of a discussion on another PR #1684 (comment) We want a reusable `IsLocalBlob` helper that is currently being rewritten multiple times. #### Which issue(s) this PR fixes Contributes: open-component-model/ocm-project#875 Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

#### What this PR does / why we need it This PR ties all the changes related to open-component-model/ocm-project#796 together in the cli package and implement oci transfer with tests. It also adds two new flags, which were taken from old ocm https://ocm.software/docs/reference/ocm-cli/transfer/componentversions/ - `FlagCopyResources = "copy-resources"` in addition, I've added an integration test, that: - creates two oci registries - uploads one artifact to the first registry - creates a cv pointing to the artifact - calls: ```go transferCMD.SetArgs([]string{ "transfer", "component-version", sourceRef, targetRef, "--config", cfgPath, "--copy-resources", // required, otherwise we wouldn't transfer oci artifacts }) ``` - verifies, that the oci artifact is in the 2nd registry #### Which issue(s) this PR fixes Contributes: open-component-model/ocm-project#796 Split PRs: - open-component-model#1730 - open-component-model#1751 - open-component-model#1736 - open-component-model#1727 - open-component-model#1718 - open-component-model#1717 --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com> Signed-off-by: Matthias Bruns <github@matthiasbruns.com> Signed-off-by: Fabian Burth <fabian.burth@sap.com> Co-authored-by: Fabian Burth <fabian.burth@sap.com>

…ent-model#1772) #### What this PR does / why we need it This PR is the result of a discussion on another PR open-component-model#1684 (comment) We want a reusable `IsLocalBlob` helper that is currently being rewritten multiple times. #### Which issue(s) this PR fixes Contributes: open-component-model/ocm-project#875 Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

…l#1751)  #### What this PR does / why we need it Required plugin contract update for Resources to be able to upload resources. It also implements `repository.ResourceRepository` in `ResourceRegistry`. Additionally, the tests used a deprecated blob construction and was updated to use the new prefered way old: `blob.NewDirectReadOnlyBlob` new: `inmemory.New` Part of open-component-model#1684 This PR aligns the plugin resource contract with the updated `repository.ResourceRepository` ```go // Repository defines the interface for storing and retrieving OCM resources // independently of component versions from a Store Implementation type Repository interface { // GetResourceCredentialConsumerIdentity resolves the identity of the given [descriptor.Resource] to use for credential resolution. GetResourceCredentialConsumerIdentity(ctx context.Context, resource *descriptor.Resource) (runtime.Identity, error) // UploadResource uploads a [descriptor.Resource] to the repository. // Returns the updated resource with repository-specific information. // The resource must be referenced in the component descriptor. // The credentials map must contain necessary authentication information to access the resource. UploadResource(ctx context.Context, res *descriptor.Resource, content blob.ReadOnlyBlob, credentials map[string]string) (*descriptor.Resource, error) // DownloadResource downloads and verifies the integrity of a [descriptor.Resource] from the repository. DownloadResource(ctx context.Context, res *descriptor.Resource, credentials map[string]string) (blob.ReadOnlyBlob, error) } ``` #### Which issue(s) this PR fixes Contributes: open-component-model/ocm-project#796 --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com> Signed-off-by: Matthias Bruns <github@matthiasbruns.com> Co-authored-by: Fabian Burth <fabian.burth@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>

#### What this PR does / why we need it This PR ties all the changes related to open-component-model/ocm-project#796 together in the cli package and implement oci transfer with tests. It also adds two new flags, which were taken from old ocm https://ocm.software/docs/reference/ocm-cli/transfer/componentversions/ - `FlagCopyResources = "copy-resources"` in addition, I've added an integration test, that: - creates two oci registries - uploads one artifact to the first registry - creates a cv pointing to the artifact - calls: ```go transferCMD.SetArgs([]string{ "transfer", "component-version", sourceRef, targetRef, "--config", cfgPath, "--copy-resources", // required, otherwise we wouldn't transfer oci artifacts }) ``` - verifies, that the oci artifact is in the 2nd registry #### Which issue(s) this PR fixes Contributes: open-component-model/ocm-project#796 Split PRs: - open-component-model#1730 - open-component-model#1751 - open-component-model#1736 - open-component-model#1727 - open-component-model#1718 - open-component-model#1717 --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com> Signed-off-by: Matthias Bruns <github@matthiasbruns.com> Signed-off-by: Fabian Burth <fabian.burth@sap.com> Co-authored-by: Fabian Burth <fabian.burth@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>

…ent-model#1772) #### What this PR does / why we need it This PR is the result of a discussion on another PR open-component-model#1684 (comment) We want a reusable `IsLocalBlob` helper that is currently being rewritten multiple times. #### Which issue(s) this PR fixes Contributes: open-component-model/ocm-project#875 Signed-off-by: Matthias Bruns <git@matthiasbruns.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>

github-actions Bot added kind/feature new feature, enhancement, improvement, extension size/l Large labels Jan 30, 2026

matthiasbruns marked this pull request as ready for review January 30, 2026 11:58

matthiasbruns requested a review from a team as a code owner January 30, 2026 11:58

jakobmoellerdev requested changes Jan 30, 2026

View reviewed changes

Comment thread bindings/go/oci/spec/transformation/v1alpha1/ctf_add_oci_artifact.go Outdated

Comment thread bindings/go/oci/spec/transformation/v1alpha1/ctf_add_oci_artifact.go Outdated

matthiasbruns force-pushed the feat/796_oci_artifact_transform_oci_bindings branch 4 times, most recently from 2d37161 to 5c78ef7 Compare February 3, 2026 07:38

github-actions Bot added component/github-actions Changes on GitHub Actions or within `.github/` directory area/documentation Documentation related labels Feb 3, 2026

matthiasbruns force-pushed the feat/796_oci_artifact_transform_oci_bindings branch 3 times, most recently from d221d85 to cfb7597 Compare February 3, 2026 07:48

fabianburth requested changes Feb 3, 2026

View reviewed changes

fabianburth reviewed Feb 3, 2026

View reviewed changes

Comment thread bindings/go/oci/transformer/get_oci_artifact_test.go

Comment thread bindings/go/oci/transformer/get_oci_artifact_test.go Outdated

fabianburth reviewed Feb 3, 2026

View reviewed changes

Comment thread bindings/go/oci/spec/transformation/v1alpha1/get_oci_artifact.go Outdated

Comment thread bindings/go/oci/transformer/get_oci_artifact.go

fabianburth reviewed Feb 3, 2026

View reviewed changes

Comment thread bindings/go/oci/spec/transformation/v1alpha1/schemas/OCIGetOCIArtifact.schema.json Outdated

matthiasbruns requested a review from jakobmoellerdev February 3, 2026 10:43

matthiasbruns force-pushed the feat/796_oci_artifact_transform_oci_bindings branch from 80c8e7f to 4f1169f Compare February 3, 2026 10:45

fabianburth previously approved these changes Feb 3, 2026

View reviewed changes

matthiasbruns dismissed fabianburth’s stale review via 06cc998 February 3, 2026 10:46

matthiasbruns force-pushed the feat/796_oci_artifact_transform_oci_bindings branch from 4f1169f to 06cc998 Compare February 3, 2026 10:46

fabianburth previously approved these changes Feb 3, 2026

View reviewed changes

jakobmoellerdev reviewed Feb 3, 2026

View reviewed changes

matthiasbruns dismissed fabianburth’s stale review via b364f01 February 3, 2026 11:55

jakobmoellerdev reviewed Feb 3, 2026

View reviewed changes

Comment thread bindings/go/oci/transformer/get_oci_artifact.go Outdated

Comment thread bindings/go/oci/transformer/get_oci_artifact.go Outdated

matthiasbruns force-pushed the feat/796_oci_artifact_transform_oci_bindings branch 2 times, most recently from d099a74 to 1736fee Compare February 3, 2026 15:50

matthiasbruns requested a review from jakobmoellerdev February 3, 2026 15:51

matthiasbruns and others added 16 commits February 13, 2026 14:20

feat: use looseref

3434962

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

Apply suggestions from code review

612074b

Signed-off-by: Matthias Bruns <github@matthiasbruns.com>

fix: clean up `--copy-local-resources and GetReferenceName

788da21

Signed-off-by: Fabian Burth <fabian.burth@sap.com>

fix: fix GetReferenceName

c3a48c0

Signed-off-by: Fabian Burth <fabian.burth@sap.com>

fix: update OCI image reference to use correct import

e68d3e1

Signed-off-by: Fabian Burth <fabian.burth@sap.com>

fix: set correct access type in tgd generator

1b82ad9

Signed-off-by: Fabian Burth <fabian.burth@sap.com>

feat: add reference name check to integration test

503bb25

Signed-off-by: Fabian Burth <fabian.burth@sap.com>

fix: tests

8e64e8c

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

chore: clean up

fbbad41

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

fix: optional cel

d1e3823

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

fix: go.mod

32eeb74

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> # Conflicts: # cli/go.mod # cli/go.sum # cli/integration/go.mod # cli/integration/go.sum

fix: localblob v1 in tests

1ea92d9

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> # Conflicts: # cli/go.mod # cli/go.sum # cli/integration/go.sum

chore: add examples in docs and update isLocal

9aff7b2

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

fix: lint

f985d42

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

fix: generated code

a1db8e4

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

chore: rebase again...

6e28caf

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

matthiasbruns force-pushed the feat/796_oci_artifact_transform_oci_bindings branch from 59a2a43 to 6e28caf Compare February 13, 2026 13:22

piotrjanik reviewed Feb 13, 2026

View reviewed changes

Comment thread cli/cmd/transfer/component-version/internal/discovery.go

piotrjanik reviewed Feb 13, 2026

View reviewed changes

Comment thread cli/cmd/transfer/component-version/internal/discovery.go

piotrjanik approved these changes Feb 13, 2026

View reviewed changes

jakobmoellerdev approved these changes Feb 13, 2026

View reviewed changes

matthiasbruns merged commit 84c98cf into open-component-model:main Feb 13, 2026
22 checks passed

matthiasbruns deleted the feat/796_oci_artifact_transform_oci_bindings branch February 13, 2026 15:18

piotrjanik mentioned this pull request Feb 16, 2026

Credential identity mismatch between OCI artifact and blob transformers #1787

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: oci artifact cli#1684

feat: oci artifact cli#1684
matthiasbruns merged 60 commits into
open-component-model:mainfrom
matthiasbruns:feat/796_oci_artifact_transform_oci_bindings

matthiasbruns commented Jan 30, 2026 •

edited by fabianburth

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakobmoellerdev left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

matthiasbruns commented Jan 30, 2026 • edited by fabianburth Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it

Which issue(s) this PR fixes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakobmoellerdev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

matthiasbruns commented Jan 30, 2026 •

edited by fabianburth

Loading