feat(796): oci artifact spec by matthiasbruns · Pull Request #1730 · open-component-model/open-component-model

matthiasbruns · 2026-02-05T16:47:11Z

What this PR does / why we need it

First PR to add oci artifact transformers in the bindings lib.
Part of #1684

GetOCIArtifactSpec will download a artifact and put it into a file defined by OutputPath or into tmp when OutputPath is empty.
The next step is to integrate the spec into the cli transfer component-version.

type GetOCIArtifactSpec struct {
	// Resource is the resource descriptor to get the OCI artifact from.
	Resource *v2.Resource `json:"resource"`
	// OutputPath is the path where the artifact should be downloaded to..
	// If empty, a temporary file will be created.
	OutputPath string `json:"outputPath,omitempty"`
}

Which issue(s) this PR fixes

Contributes: open-component-model/ocm-project#796

jakobmoellerdev

mostly lgtm, just smaller corrections and questions I believe

#### What this PR does / why we need it This PR is based on the discussion on #1730 (comment) It implements the `Resolver` interface and provides a static way to resolve `credentials`. This `Resolver` does not use the graph. If you have an idea on how to integrate static credentials into the dag, I am happy to change the implementation. #### Which issue(s) this PR fixes Contributes: open-component-model/ocm-project#796 --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> # Conflicts: # bindings/go/oci/integration/go.sum

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> # Conflicts: # bindings/go/oci/integration/go.sum

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

Co-authored-by: Fabian Burth <fabian.burth@sap.com> Signed-off-by: Matthias Bruns <github@matthiasbruns.com>

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

Skarlso

Generally okay, just a few little questions. :)

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

…_spec

#### What this PR does / why we need it This PR ties all the changes related to open-component-model/ocm-project#796 together in the cli package and implement oci transfer with tests. It also adds two new flags, which were taken from old ocm https://ocm.software/docs/reference/ocm-cli/transfer/componentversions/ - `FlagCopyResources = "copy-resources"` in addition, I've added an integration test, that: - creates two oci registries - uploads one artifact to the first registry - creates a cv pointing to the artifact - calls: ```go transferCMD.SetArgs([]string{ "transfer", "component-version", sourceRef, targetRef, "--config", cfgPath, "--copy-resources", // required, otherwise we wouldn't transfer oci artifacts }) ``` - verifies, that the oci artifact is in the 2nd registry #### Which issue(s) this PR fixes Contributes: open-component-model/ocm-project#796 Split PRs: - #1730 - #1751 - #1736 - #1727 - #1718 - #1717 --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com> Signed-off-by: Matthias Bruns <github@matthiasbruns.com> Signed-off-by: Fabian Burth <fabian.burth@sap.com> Co-authored-by: Fabian Burth <fabian.burth@sap.com>

#### What this PR does / why we need it This PR ties all the changes related to open-component-model/ocm-project#796 together in the cli package and implement oci transfer with tests. It also adds two new flags, which were taken from old ocm https://ocm.software/docs/reference/ocm-cli/transfer/componentversions/ - `FlagCopyResources = "copy-resources"` in addition, I've added an integration test, that: - creates two oci registries - uploads one artifact to the first registry - creates a cv pointing to the artifact - calls: ```go transferCMD.SetArgs([]string{ "transfer", "component-version", sourceRef, targetRef, "--config", cfgPath, "--copy-resources", // required, otherwise we wouldn't transfer oci artifacts }) ``` - verifies, that the oci artifact is in the 2nd registry #### Which issue(s) this PR fixes Contributes: open-component-model/ocm-project#796 Split PRs: - open-component-model#1730 - open-component-model#1751 - open-component-model#1736 - open-component-model#1727 - open-component-model#1718 - open-component-model#1717 --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com> Signed-off-by: Matthias Bruns <github@matthiasbruns.com> Signed-off-by: Fabian Burth <fabian.burth@sap.com> Co-authored-by: Fabian Burth <fabian.burth@sap.com>

Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>

#### What this PR does / why we need it This PR ties all the changes related to open-component-model/ocm-project#796 together in the cli package and implement oci transfer with tests. It also adds two new flags, which were taken from old ocm https://ocm.software/docs/reference/ocm-cli/transfer/componentversions/ - `FlagCopyResources = "copy-resources"` in addition, I've added an integration test, that: - creates two oci registries - uploads one artifact to the first registry - creates a cv pointing to the artifact - calls: ```go transferCMD.SetArgs([]string{ "transfer", "component-version", sourceRef, targetRef, "--config", cfgPath, "--copy-resources", // required, otherwise we wouldn't transfer oci artifacts }) ``` - verifies, that the oci artifact is in the 2nd registry #### Which issue(s) this PR fixes Contributes: open-component-model/ocm-project#796 Split PRs: - open-component-model#1730 - open-component-model#1751 - open-component-model#1736 - open-component-model#1727 - open-component-model#1718 - open-component-model#1717 --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com> Signed-off-by: Matthias Bruns <github@matthiasbruns.com> Signed-off-by: Fabian Burth <fabian.burth@sap.com> Co-authored-by: Fabian Burth <fabian.burth@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>

matthiasbruns requested a review from a team as a code owner February 5, 2026 16:47

github-actions Bot added kind/feature new feature, enhancement, improvement, extension size/l Large labels Feb 5, 2026

matthiasbruns force-pushed the feat/796_oci_artifact_transform_oci_bindings_spec branch from 9e49bde to a4cde09 Compare February 5, 2026 16:48

matthiasbruns mentioned this pull request Feb 5, 2026

feat: oci artifact cli #1684

Merged

fabianburth previously approved these changes Feb 6, 2026

View reviewed changes

matthiasbruns dismissed fabianburth’s stale review via 84e5a34 February 6, 2026 09:18

piotrjanik reviewed Feb 6, 2026

View reviewed changes

Comment thread bindings/go/oci/transformer/get_oci_artifact.go Outdated

piotrjanik previously approved these changes Feb 6, 2026

View reviewed changes

jakobmoellerdev reviewed Feb 6, 2026

View reviewed changes

matthiasbruns dismissed piotrjanik’s stale review via 962f9ac February 6, 2026 13:43

matthiasbruns force-pushed the feat/796_oci_artifact_transform_oci_bindings_spec branch from 47ad403 to a55b542 Compare February 6, 2026 14:37

matthiasbruns mentioned this pull request Feb 7, 2026

feat: add static credentials resolver #1736

Merged

jakobmoellerdev reviewed Feb 9, 2026

View reviewed changes

Comment thread bindings/go/oci/integration/integration_test.go Outdated

matthiasbruns force-pushed the feat/796_oci_artifact_transform_oci_bindings_spec branch from d7941cb to b898d7f Compare February 9, 2026 08:28

matthiasbruns force-pushed the feat/796_oci_artifact_transform_oci_bindings_spec branch 2 times, most recently from 7d22f79 to 70e74bf Compare February 9, 2026 12:14

matthiasbruns requested review from fabianburth, jakobmoellerdev and piotrjanik February 9, 2026 12:29

matthiasbruns added 9 commits February 9, 2026 15:40

feat(796): oci artifact spec

45b338f

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> # Conflicts: # bindings/go/oci/integration/go.sum

fix: schema registration

b8978fb

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

fix: digest schema handling

708dbf6

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

chore: review feedback

ebe74bf

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

fix: update spec gen

49075ea

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com> # Conflicts: # bindings/go/oci/integration/go.sum

chore: move transformer tests

d454bcc

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

chore: update test docs

446a5d7

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

feat: use static credentials resolver

0de19a2

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

chore: rebase & tidy 🧹

da3270e

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

matthiasbruns force-pushed the feat/796_oci_artifact_transform_oci_bindings_spec branch from 70e74bf to da3270e Compare February 9, 2026 14:41

piotrjanik reviewed Feb 9, 2026

View reviewed changes

Comment thread bindings/go/oci/transformer/output.go Outdated

chore: .bin

5d26a34

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

fabianburth reviewed Feb 9, 2026

View reviewed changes

matthiasbruns and others added 5 commits February 9, 2026 16:10

chore: test output handling

3fa7b50

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

chore: fix docs

102cd01

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

Update bindings/go/oci/transformer/get_oci_artifact_test.go

df8ad53

Co-authored-by: Fabian Burth <fabian.burth@sap.com> Signed-off-by: Matthias Bruns <github@matthiasbruns.com>

chore: apply review

795d5f4

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

feat: credentials 0.0.7

1333095

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

fabianburth previously approved these changes Feb 9, 2026

View reviewed changes

matthiasbruns requested review from fabianburth and piotrjanik February 9, 2026 16:02

matthiasbruns enabled auto-merge (squash) February 9, 2026 16:03

Skarlso reviewed Feb 9, 2026

View reviewed changes

Comment thread bindings/go/oci/transformer/get_oci_artifact.go

Comment thread bindings/go/oci/transformer/output.go

Comment thread bindings/go/oci/transformer/get_oci_artifact.go Outdated

chore: apply review

532fa45

On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>

matthiasbruns dismissed fabianburth’s stale review via 532fa45 February 9, 2026 17:38

matthiasbruns requested a review from Skarlso February 9, 2026 17:40

Skarlso approved these changes Feb 9, 2026

View reviewed changes

Merge branch 'main' into feat/796_oci_artifact_transform_oci_bindings…

24cf28d

…_spec

piotrjanik approved these changes Feb 10, 2026

View reviewed changes

matthiasbruns merged commit 2b87daf into open-component-model:main Feb 10, 2026
19 checks passed

morri-son pushed a commit to morri-son/open-component-model that referenced this pull request Feb 18, 2026

feat(796): oci artifact spec (open-component-model#1730)

225ef55

Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(796): oci artifact spec#1730

feat(796): oci artifact spec#1730
matthiasbruns merged 17 commits into
open-component-model:mainfrom
matthiasbruns:feat/796_oci_artifact_transform_oci_bindings_spec

matthiasbruns commented Feb 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

jakobmoellerdev left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Skarlso left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

matthiasbruns commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it

Which issue(s) this PR fixes

Uh oh!

Uh oh!

jakobmoellerdev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Skarlso left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

matthiasbruns commented Feb 5, 2026 •

edited

Loading