Skip to content

fix: 743 add semver check cli tests#1341

Merged
matthiasbruns merged 19 commits into
open-component-model:mainfrom
matthiasbruns:fix/743_add_cv_version_regexp_tests
Dec 11, 2025
Merged

fix: 743 add semver check cli tests#1341
matthiasbruns merged 19 commits into
open-component-model:mainfrom
matthiasbruns:fix/743_add_cv_version_regexp_tests

Conversation

@matthiasbruns

@matthiasbruns matthiasbruns commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Adds semver checks to ocm add cv analog to ocm get cv

Which issue(s) this PR fixes

Fixes: open-component-model/ocm-project#743
Fixes: open-component-model/ocm-project#752

@github-actions github-actions Bot added the kind/bugfix Bug label Dec 5, 2025
@github-actions github-actions Bot added the size/l Large label Dec 5, 2025
@github-actions github-actions Bot added the size/m Medium label Dec 5, 2025
@matthiasbruns matthiasbruns force-pushed the fix/743_add_cv_version_regexp_tests branch from 59d3c2a to a69c4c6 Compare December 5, 2025 08:32
@matthiasbruns matthiasbruns changed the title fix: 743 add semver check fix: 743 add semver check cli tests Dec 5, 2025
matthiasbruns added a commit that referenced this pull request Dec 5, 2025
<!-- markdownlint-disable MD041 -->
#### What this PR does / why we need it
Adds semver checks to `ocm add cv` analog to `ocm get cv`

#### Which issue(s) this PR fixes
Contributes
open-component-model/ocm-project#743

Check
#1341
how it is integrated

---------

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns matthiasbruns force-pushed the fix/743_add_cv_version_regexp_tests branch from 1a3863f to 1b2d16c Compare December 5, 2025 11:50
@github-actions github-actions Bot added the size/s Small label Dec 5, 2025
@matthiasbruns matthiasbruns force-pushed the fix/743_add_cv_version_regexp_tests branch from 1b2d16c to 656ffd6 Compare December 5, 2025 11:51
Comment thread cli/integration/go.mod Outdated
Comment thread cli/integration/plugin_registry_list_integration_test.go Outdated
@matthiasbruns matthiasbruns marked this pull request as ready for review December 9, 2025 14:28
@matthiasbruns matthiasbruns requested a review from a team as a code owner December 9, 2025 14:28
jakobmoellerdev pushed a commit that referenced this pull request Dec 9, 2025
<!-- markdownlint-disable MD041 -->
#### What this PR does / why we need it
Fixes the invalid `label` type in `componentReference` to support
`object`s.

#### Which issue(s) this PR fixes
Contributes
open-component-model/ocm-project#743

Used in
#1341

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
Comment thread cli/integration/go.mod Outdated
@fabianburth

Copy link
Copy Markdown
Contributor

I think we also wanted to make validation failures a warning instead of an error for get cv, right?

ocmbot Bot and others added 10 commits December 10, 2025 08:43
…exp_constructor

fix(deps): update ocm monorepo go module dependencies to cb295d4 (open-component-model#1338)

This PR contains the following updates:

| Package | Type | Update | Change | OpenSSF |
|---|---|---|---|---|
|
[ocm.software/open-component-model/bindings/go/descriptor/normalisation](https://redirect.github.com/open-component-model/open-component-model)
| require | digest | `24b8f80` -> `cb295d4` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/open-component-model/open-component-model/badge)](https://securityscorecards.dev/viewer/?uri=github.com/open-component-model/open-component-model)
|
|
[ocm.software/open-component-model/bindings/go/descriptor/normalisation](https://redirect.github.com/open-component-model/open-component-model)
| indirect | digest | `24b8f80` -> `cb295d4` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/open-component-model/open-component-model/badge)](https://securityscorecards.dev/viewer/?uri=github.com/open-component-model/open-component-model)
|
|
[ocm.software/open-component-model/bindings/go/descriptor/runtime](https://redirect.github.com/open-component-model/open-component-model)
| require | digest | `24b8f80` -> `cb295d4` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/open-component-model/open-component-model/badge)](https://securityscorecards.dev/viewer/?uri=github.com/open-component-model/open-component-model)
|
|
[ocm.software/open-component-model/bindings/go/descriptor/runtime](https://redirect.github.com/open-component-model/open-component-model)
| indirect | digest | `24b8f80` -> `cb295d4` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/open-component-model/open-component-model/badge)](https://securityscorecards.dev/viewer/?uri=github.com/open-component-model/open-component-model)
|
|
[ocm.software/open-component-model/bindings/go/input/utf8](https://redirect.github.com/open-component-model/open-component-model)
| indirect | digest | `24b8f80` -> `cb295d4` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/open-component-model/open-component-model/badge)](https://securityscorecards.dev/viewer/?uri=github.com/open-component-model/open-component-model)
|
|
[ocm.software/open-component-model/bindings/go/input/utf8](https://redirect.github.com/open-component-model/open-component-model)
| require | digest | `24b8f80` -> `cb295d4` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/open-component-model/open-component-model/badge)](https://securityscorecards.dev/viewer/?uri=github.com/open-component-model/open-component-model)
|
|
[ocm.software/open-component-model/bindings/go/rsa](https://redirect.github.com/open-component-model/open-component-model)
| require | digest | `24b8f80` -> `cb295d4` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/open-component-model/open-component-model/badge)](https://securityscorecards.dev/viewer/?uri=github.com/open-component-model/open-component-model)
|
|
[ocm.software/open-component-model/bindings/go/rsa](https://redirect.github.com/open-component-model/open-component-model)
| indirect | digest | `24b8f80` -> `cb295d4` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/open-component-model/open-component-model/badge)](https://securityscorecards.dev/viewer/?uri=github.com/open-component-model/open-component-model)
|
|
[ocm.software/open-component-model/bindings/go/signing](https://redirect.github.com/open-component-model/open-component-model)
| require | digest | `24b8f80` -> `cb295d4` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/open-component-model/open-component-model/badge)](https://securityscorecards.dev/viewer/?uri=github.com/open-component-model/open-component-model)
|
|
[ocm.software/open-component-model/bindings/go/signing](https://redirect.github.com/open-component-model/open-component-model)
| indirect | digest | `24b8f80` -> `cb295d4` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/open-component-model/open-component-model/badge)](https://securityscorecards.dev/viewer/?uri=github.com/open-component-model/open-component-model)
|
|
[ocm.software/open-component-model/cli](https://redirect.github.com/open-component-model/open-component-model)
| require | digest | `24b8f80` -> `cb295d4` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/open-component-model/open-component-model/badge)](https://securityscorecards.dev/viewer/?uri=github.com/open-component-model/open-component-model)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

📅 **Schedule**: Branch creation - At 10:00 PM and 12:00 AM through 06:59
AM ( * 22,0-6 * * * ) (UTC), Automerge - At any time (no schedule
defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNzMuMSIsInVwZGF0ZWRJblZlciI6IjQxLjE3My4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: ocmbot[bot] <125909804+ocmbot[bot]@users.noreply.github.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com>

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com>

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com>

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com>

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com>

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com>

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com>

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com>

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns matthiasbruns force-pushed the fix/743_add_cv_version_regexp_tests branch from f151794 to 09f2bdf Compare December 10, 2025 07:43
On-behalf-of: SAP <matthias.bruns@sap.com>

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns matthiasbruns force-pushed the fix/743_add_cv_version_regexp_tests branch from b072d5c to ac93166 Compare December 10, 2025 07:57
On-behalf-of: SAP <matthias.bruns@sap.com>

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns matthiasbruns force-pushed the fix/743_add_cv_version_regexp_tests branch from 5e57f59 to a8dfd6d Compare December 10, 2025 11:17
On-behalf-of: SAP <matthias.bruns@sap.com>

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com>

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
Comment thread cli/cmd/get/component-version/cmd.go
@gitguardian

gitguardian Bot commented Dec 10, 2025

Copy link
Copy Markdown

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Comment thread cli/cmd/cmd_test.go
fabianburth
fabianburth previously approved these changes Dec 11, 2025
On-behalf-of: SAP <matthias.bruns@sap.com>

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns matthiasbruns force-pushed the fix/743_add_cv_version_regexp_tests branch from 9b3f4d2 to f375709 Compare December 11, 2025 08:52
@matthiasbruns matthiasbruns enabled auto-merge (squash) December 11, 2025 09:02
@matthiasbruns matthiasbruns merged commit 285f164 into open-component-model:main Dec 11, 2025
21 checks passed
@matthiasbruns matthiasbruns deleted the fix/743_add_cv_version_regexp_tests branch December 11, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce severity for version validation in ocm get cv from error to warning ocm add cv accepts version that do not match version regexp

5 participants