Just wondering, instead of having concrete semver checks, shouldn't we rather try to have a thorough json schema for the constructor and validate the entire constructors against that json schema?

Just wondering, instead of having concrete semver checks, shouldn't we rather try to have a thorough json schema for the constructor and validate the entire constructors against that json schema?

something like this?

// Component defines a named and versioned component containing dependencies such as sources, resources and
// references pointing to further component versions.
// +k8s:deepcopy-gen=true
type Component struct {
	ComponentMeta `json:",inline"`
	Provider      Provider    `json:"-"`
	Resources     []Resource  `json:"-"`
	Sources       []Source    `json:"-"`
	References    []Reference `json:"-"`
}

func (a *Component) Validate() error {
	if _, err := semver.NewConstraint(a.Version); err != nil {
		return errors.Join(ErrInvalidSemverVersion, fmt.Errorf("component %q has invalid semver version %q: %w", a.Name, a.Version, err))
	}
	return nil
}

	if err := constructorv1.ValidateRawYAML(constructorData); err != nil {
		return nil, fmt.Errorf("validating component constructor %q failed: %w", path, err)
	}

I tried to validate the constructor against the existing schema and it fails with basically every existing cli test

Error: getting component constructor failed: validating component constructor "/var/folders/vp/119yd9r50j7_bszfqvsyk8500000gn/T/Test_Add_Component_Version2597195195/001/component-constructor.yaml" failed: jsonschema validation failed with 'open-component-model/cli/cmd/resources/schema-2020-12.json#'
- at '': 'oneOf' failed, none matched
  - at '': missing property 'components'
  - at '/resources/0': 'oneOf' failed, none matched
    - at '/resources/0': missing properties 'version', 'relation', 'access'
    - at '/resources/0': missing property 'relation'

@jakobmoellerdev since you built the schema - how to proceed here? should I update every existing cli test or revisit the schema since it's not really in use right now afaik

https://github.com/open-component-model/open-component-model/pull/1316/files#diff-5a9e426f588a47f64ab19f8b5fd53025f85dc02d3aac6a681b420a8c07948906R368

Just a note. are you sure that this shouldnt just be a call on the data in the cli? otherwise everyone will loose to read a constructor that does not conform to the schema (i.e. when they want to build them together step by step from fragments)

haven't thought about it - wdyt? I am usually for more strict handling everywhere than fragmented behaviour. I can only check it in CLI for now, but since we have a spec, and we are parsing from it, I'd assume that we would do the check at this point for every model tbh

Just a note. are you sure that this shouldnt just be a call on the data in the cli? otherwise everyone will loose to read a constructor that does not conform to the schema (i.e. when they want to build them together step by step from fragments)

haven't thought about it - wdyt? I am usually for more strict handling everywhere than fragmented behaviour. I can only check it in CLI for now, but since we have a spec, and we are parsing from it, I'd assume that we would do the check at this point for every model tbh

In general this is great but you have to remember that were currently restricting marshalling itself. I am happy to default to use this marshaller but be able to have an unsafe version as well. since this lib is so foundational we must assume folks want to get unfinished constructors into the lib

Just a note. are you sure that this shouldnt just be a call on the data in the cli? otherwise everyone will loose to read a constructor that does not conform to the schema (i.e. when they want to build them together step by step from fragments)

haven't thought about it - wdyt? I am usually for more strict handling everywhere than fragmented behaviour. I can only check it in CLI for now, but since we have a spec, and we are parsing from it, I'd assume that we would do the check at this point for every model tbh

In general this is great but you have to remember that were currently restricting marshalling itself. I am happy to default to use this marshaller but be able to have an unsafe version as well. since this lib is so foundational we must assume folks want to get unfinished constructors into the lib

Added https://github.com/open-component-model/open-component-model/pull/1317/files#diff-35b4b1f537a1b2d5258b540d47da10402c97cf1dc45bcacf82009cff106a0700R51 and tests for it

The PR linked in your PR description does not contain any additional information.

added a bit info to the cli pr