feat: 743 loosen compref version parsing#1393
Closed
matthiasbruns wants to merge 3 commits into
Closed
Conversation
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
piotrjanik
reviewed
Dec 10, 2025
| if tc.expected.Type != "" { | ||
| var opts []Option | ||
| if tc.ignoreSemverValidation { | ||
| opts = append(opts, IgnoreSemverCompatibility()) |
Contributor
There was a problem hiding this comment.
Currentyl it is used only in tests, will it be added to cli or somewhere else?
Contributor
Author
There was a problem hiding this comment.
i just saw that it's cli only...
matthiasbruns
added a commit
that referenced
this pull request
Dec 11, 2025
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Adds semver checks to `ocm add cv` analog to `ocm get cv` - This PR will only update cli and add tests when #1317 is merged to verify, that the constructor validation works as expected - This Pr also reduces the logging level in `get cv` when requesting an invalid version #1393 #### Which issue(s) this PR fixes Fixes: open-component-model/ocm-project#743 Fixes: open-component-model/ocm-project#752 --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com> Co-authored-by: ocmbot[bot] <125909804+ocmbot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
get cvwhen requesting an invalid versionWhich issue(s) this PR fixes
Contributes: open-component-model/ocm-project#752
Needed for #1341