Skip to content

feat: add object support for labels#1383

Merged
jakobmoellerdev merged 2 commits into
open-component-model:mainfrom
matthiasbruns:fix/743_constructor_label_object_support
Dec 9, 2025
Merged

feat: add object support for labels#1383
jakobmoellerdev merged 2 commits into
open-component-model:mainfrom
matthiasbruns:fix/743_constructor_label_object_support

Conversation

@matthiasbruns

@matthiasbruns matthiasbruns commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Fixes the invalid label type in constructor schema.json to support objects.

Which issue(s) this PR fixes

Contributes open-component-model/ocm-project#743

Used in #1341

On-behalf-of: SAP <matthias.bruns@sap.com>

Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
@matthiasbruns matthiasbruns requested a review from a team as a code owner December 9, 2025 14:37
@github-actions github-actions Bot added kind/feature new feature, enhancement, improvement, extension size/s Small labels Dec 9, 2025

@piotrjanik piotrjanik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabianburth fabianburth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is a bit misleading. I believe this affects all labels. But seems correct to me as this aligns with our descriptor schema, unless @jakobmoellerdev had a particular reason to not allow this here.

@jakobmoellerdev jakobmoellerdev enabled auto-merge (squash) December 9, 2025 17:42
@jakobmoellerdev jakobmoellerdev merged commit 9556f8f into open-component-model:main Dec 9, 2025
31 checks passed
@matthiasbruns matthiasbruns deleted the fix/743_constructor_label_object_support branch December 10, 2025 07:38
@matthiasbruns

Copy link
Copy Markdown
Contributor Author

PR description is a bit misleading. I believe this affects all labels. But seems correct to me as this aligns with our descriptor schema, unless @jakobmoellerdev had a particular reason to not allow this here.

updates the descirption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature new feature, enhancement, improvement, extension size/s Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants