Skip to content

Set confirmation level#304

Merged
tmcgilchrist merged 1 commit intoocurrent:masterfrom
tmcgilchrist:confirm
Feb 8, 2022
Merged

Set confirmation level#304
tmcgilchrist merged 1 commit intoocurrent:masterfrom
tmcgilchrist:confirm

Conversation

@tmcgilchrist
Copy link
Copy Markdown
Member

@tmcgilchrist tmcgilchrist commented Dec 9, 2021

Explicitly set confirmation levels to allow for manually triggered jobs.

Pulling this across from @TheLortex fork for tarides/tezos-ci

Copy link
Copy Markdown
Contributor

@talex5 talex5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Would be good to state in the PR what this is useful for, though.

@TheLortex
Copy link
Copy Markdown

The goal is to implement CI jobs that can be run manually. Using this patch, it's possible to achieve that by setting them to a higher confirmation level than the other jobs.

@TheLortex
Copy link
Copy Markdown

I believe there should be a similar patch in current_ocluster as well

@MisterDA
Copy link
Copy Markdown
Contributor

MisterDA commented Feb 7, 2022

Please consider merging this! :)

@tmcgilchrist tmcgilchrist merged commit 11d48f2 into ocurrent:master Feb 8, 2022
@tmcgilchrist tmcgilchrist deleted the confirm branch February 8, 2022 03:30
tmcgilchrist added a commit to tmcgilchrist/opam-repository that referenced this pull request Apr 7, 2022
…, current_github, current_git, current_examples, current_docker and current (0.6)

CHANGES:

Core:

- Implement labelling of clusters on the Graphviz diagram
  (@ewanmellor ocurrent/ocurrent#255)

- Abort propagation on constant/equal changes (@art-w ocurrent/ocurrent#318)

API:

- GitHub: Record build status using CheckRun (@tmcgilchrist ocurrent/ocurrent#279)

- GitHub: Add details_url to check_run. (@tmcgilchrist ocurrent/ocurrent#282)

- GitHub: Add Current_github.Api.cmdliner_opt to allow writing
  pipelines which can optionally be run as GitHub apps. (@talex5 ocurrent/ocurrent#281)

- GitHub: Provide markdown details for CheckRun. (@tmcgilchrist ocurrent/ocurrent#288)

- GitHub: Fix wrong name used for repository (@tmcgilchrist ocurrent/ocurrent#289 ocurrent/ocurrent#290)

- GitHub: Support Github rebuild via webooks. (@tmcgilchrist ocurrent/ocurrent#283)

- GitHub: monitor GraphQL queries (@art-w ocurrent/ocurrent#298)

- GitHub: Limit CheckRunStatus summary and text fields to 65535.
  (@tmcgilchrist ocurrent/ocurrent#300)

- GitHub: Log extra context for Webhook validation failure.
  (@tmcgilchrist ocurrent/ocurrent#302)

- GitLab: Initial GitLab plugin work. (@tmcgilchrist ocurrent/ocurrent#299)

- Git: Make git reset less verbose (@kit-ty-kate ocurrent/ocurrent#293)

Web UI:

- Use Lwt.pause instead of Lwt_unix.yield (@MisterDA ocurrent/ocurrent#297)

- Use `ansi` instead of `current_ansi` (@samoht ocurrent/ocurrent#321)

- Show line numbers and allow jumping to specific lines in job
  logs (@punchagan ocurrent/ocurrent#309)

Docker:

- Explicitly set confirmation levels to allow for
  manually triggered jobs. (@tmcgilchrist ocurrent/ocurrent#304)

- Stop using `Dockerfile.t` completely and use strings instead.
  (@MisterDA ocurrent/ocurrent#301 ocurrent/ocurrent#316)

Other:

- Update to cohttp 4.0.0 (ocurrent/ocurrent#274, @talex5)

- Move `Current_incr` to its own repository (ocurrent/ocurrent#284, @talex5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants