Initial CreateRun and set status.#279
Conversation
talex5
left a comment
There was a problem hiding this comment.
Looks good! (minor comments inline)
What happened to the plan to add a type parameter to Api.t, to enforce the rule that checks can only be used with apps?
Looks like ocaml/opam-repository#19046 is taking a long time to get merged, but we can go ahead with the submodule to get this merged for now.
plugins/github/api.ml
Outdated
| let name t = | ||
| match String.split_on_char '/' t.owner_name with | ||
| | [owner;repo_name] -> Some (owner, repo_name) | ||
| | _ -> None |
There was a problem hiding this comment.
It seems we always have both and this can't really fail in practice, the refactoring looks like this
5da9b03
There was a problem hiding this comment.
That looks good to me (with old code removed rather than commented).
I like the idea it just started to get quite invasive and I abandoned it.
Agree, I'll clean this up and merge. |
talex5
left a comment
There was a problem hiding this comment.
Looks good! I guess the ocaml-github vendoring should be removed now that the release is complete.
d3b412e to
1af648c
Compare
Refactor owner_name into split owner / repo pair.
|
Thanks! |
…, current_github, current_git, current_examples, current_docker and current (0.6) CHANGES: Core: - Implement labelling of clusters on the Graphviz diagram (@ewanmellor ocurrent/ocurrent#255) - Abort propagation on constant/equal changes (@art-w ocurrent/ocurrent#318) API: - GitHub: Record build status using CheckRun (@tmcgilchrist ocurrent/ocurrent#279) - GitHub: Add details_url to check_run. (@tmcgilchrist ocurrent/ocurrent#282) - GitHub: Add Current_github.Api.cmdliner_opt to allow writing pipelines which can optionally be run as GitHub apps. (@talex5 ocurrent/ocurrent#281) - GitHub: Provide markdown details for CheckRun. (@tmcgilchrist ocurrent/ocurrent#288) - GitHub: Fix wrong name used for repository (@tmcgilchrist ocurrent/ocurrent#289 ocurrent/ocurrent#290) - GitHub: Support Github rebuild via webooks. (@tmcgilchrist ocurrent/ocurrent#283) - GitHub: monitor GraphQL queries (@art-w ocurrent/ocurrent#298) - GitHub: Limit CheckRunStatus summary and text fields to 65535. (@tmcgilchrist ocurrent/ocurrent#300) - GitHub: Log extra context for Webhook validation failure. (@tmcgilchrist ocurrent/ocurrent#302) - GitLab: Initial GitLab plugin work. (@tmcgilchrist ocurrent/ocurrent#299) - Git: Make git reset less verbose (@kit-ty-kate ocurrent/ocurrent#293) Web UI: - Use Lwt.pause instead of Lwt_unix.yield (@MisterDA ocurrent/ocurrent#297) - Use `ansi` instead of `current_ansi` (@samoht ocurrent/ocurrent#321) - Show line numbers and allow jumping to specific lines in job logs (@punchagan ocurrent/ocurrent#309) Docker: - Explicitly set confirmation levels to allow for manually triggered jobs. (@tmcgilchrist ocurrent/ocurrent#304) - Stop using `Dockerfile.t` completely and use strings instead. (@MisterDA ocurrent/ocurrent#301 ocurrent/ocurrent#316) Other: - Update to cohttp 4.0.0 (ocurrent/ocurrent#274, @talex5) - Move `Current_incr` to its own repository (ocurrent/ocurrent#284, @talex5)
Sample run on this PR tmcgilchrist/ocaml-bitbucket#19
Should eventually be an alternative for setting the status against a commit.