Skip to content

Initial GitLab plugin work.#299

Merged
tmcgilchrist merged 1 commit intoocurrent:masterfrom
tmcgilchrist:gitlab_plugin
Dec 1, 2021
Merged

Initial GitLab plugin work.#299
tmcgilchrist merged 1 commit intoocurrent:masterfrom
tmcgilchrist:gitlab_plugin

Conversation

@tmcgilchrist
Copy link
Copy Markdown
Member

@tmcgilchrist tmcgilchrist commented Oct 25, 2021

Very much a WIP

  • Basic single repo builder doc/examples/gitlab.ml
  • Webhook validation with secrets
  • Follow updates to Merge Request
  • Gather all_refs to trigger builds against all branches and merge requests
  • Support rate limits in HTTP Headers.
  • Enumerate the projects configured with web hooks for ocurrent_gitlab

@tmcgilchrist tmcgilchrist force-pushed the gitlab_plugin branch 3 times, most recently from 04ae850 to 96fc3a0 Compare November 11, 2021 22:31
@tmcgilchrist tmcgilchrist marked this pull request as ready for review November 29, 2021 03:39
@tmcgilchrist tmcgilchrist requested a review from talex5 November 29, 2021 04:08
Copy link
Copy Markdown
Contributor

@talex5 talex5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Minor comments inline.

from (Docker.Image.hash base) @@
workdir "/src" @@
add ~src:["*.opam"] ~dst:"/src/" () @@
run "opam install . --show-actions --deps-only -t | awk '/- install/{print $3}' | xargs opam depext -iy" @@
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably switch to opam-2.1!

)
~finally:(fun () -> close_in ch)

(* TODO Rework how we get a token. *)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What needs to be changed?

@tmcgilchrist tmcgilchrist force-pushed the gitlab_plugin branch 2 times, most recently from ea1ab71 to 5baa8f0 Compare November 30, 2021 06:38
Includes support for:
 * Authenticated API for following Repos and Refs, and recording CI
 status against a Commit.
 * Anonymous following the head_of a git ref
 * webhook updates for Merge Requests and Push events
 * prometheus metrics for webhook events received

Uses GitLab REST bindings from gitlab-unix.
@tmcgilchrist tmcgilchrist merged commit 0f4a5bc into ocurrent:master Dec 1, 2021
@tmcgilchrist tmcgilchrist deleted the gitlab_plugin branch December 1, 2021 23:42
tmcgilchrist added a commit to tmcgilchrist/opam-repository that referenced this pull request Apr 7, 2022
…, current_github, current_git, current_examples, current_docker and current (0.6)

CHANGES:

Core:

- Implement labelling of clusters on the Graphviz diagram
  (@ewanmellor ocurrent/ocurrent#255)

- Abort propagation on constant/equal changes (@art-w ocurrent/ocurrent#318)

API:

- GitHub: Record build status using CheckRun (@tmcgilchrist ocurrent/ocurrent#279)

- GitHub: Add details_url to check_run. (@tmcgilchrist ocurrent/ocurrent#282)

- GitHub: Add Current_github.Api.cmdliner_opt to allow writing
  pipelines which can optionally be run as GitHub apps. (@talex5 ocurrent/ocurrent#281)

- GitHub: Provide markdown details for CheckRun. (@tmcgilchrist ocurrent/ocurrent#288)

- GitHub: Fix wrong name used for repository (@tmcgilchrist ocurrent/ocurrent#289 ocurrent/ocurrent#290)

- GitHub: Support Github rebuild via webooks. (@tmcgilchrist ocurrent/ocurrent#283)

- GitHub: monitor GraphQL queries (@art-w ocurrent/ocurrent#298)

- GitHub: Limit CheckRunStatus summary and text fields to 65535.
  (@tmcgilchrist ocurrent/ocurrent#300)

- GitHub: Log extra context for Webhook validation failure.
  (@tmcgilchrist ocurrent/ocurrent#302)

- GitLab: Initial GitLab plugin work. (@tmcgilchrist ocurrent/ocurrent#299)

- Git: Make git reset less verbose (@kit-ty-kate ocurrent/ocurrent#293)

Web UI:

- Use Lwt.pause instead of Lwt_unix.yield (@MisterDA ocurrent/ocurrent#297)

- Use `ansi` instead of `current_ansi` (@samoht ocurrent/ocurrent#321)

- Show line numbers and allow jumping to specific lines in job
  logs (@punchagan ocurrent/ocurrent#309)

Docker:

- Explicitly set confirmation levels to allow for
  manually triggered jobs. (@tmcgilchrist ocurrent/ocurrent#304)

- Stop using `Dockerfile.t` completely and use strings instead.
  (@MisterDA ocurrent/ocurrent#301 ocurrent/ocurrent#316)

Other:

- Update to cohttp 4.0.0 (ocurrent/ocurrent#274, @talex5)

- Move `Current_incr` to its own repository (ocurrent/ocurrent#284, @talex5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants