Skip to content

GitHub API: monitor GraphQL queries#298

Merged
tmcgilchrist merged 2 commits intoocurrent:masterfrom
art-w:github-monitors
Oct 26, 2021
Merged

GitHub API: monitor GraphQL queries#298
tmcgilchrist merged 2 commits intoocurrent:masterfrom
art-w:github-monitors

Conversation

@art-w
Copy link
Copy Markdown
Contributor

@art-w art-w commented Oct 25, 2021

We are planning to request more information from the GitHub API inside current-bench (for example the PR title and author). The Current_github.Api uses two sets of monitors for the head_commit and ci_refs with some large similarities and semantics that we would need to replicate.

This PR provides a refactoring of the common features and exposes the resulting interface to the users. The monitored GraphQL queries have the same lifetime as the head_commit/refs and report the rate limitations / logs / etc.

@gs0510
Copy link
Copy Markdown
Contributor

gs0510 commented Oct 25, 2021

cc @tmcgilchrist Can you take a look at this? Thank you!

@tmcgilchrist
Copy link
Copy Markdown
Member

Looks good to me, interesting use of extensible variants. 👍🏻

@tmcgilchrist tmcgilchrist merged commit 9752920 into ocurrent:master Oct 26, 2021
tmcgilchrist added a commit to tmcgilchrist/opam-repository that referenced this pull request Apr 7, 2022
…, current_github, current_git, current_examples, current_docker and current (0.6)

CHANGES:

Core:

- Implement labelling of clusters on the Graphviz diagram
  (@ewanmellor ocurrent/ocurrent#255)

- Abort propagation on constant/equal changes (@art-w ocurrent/ocurrent#318)

API:

- GitHub: Record build status using CheckRun (@tmcgilchrist ocurrent/ocurrent#279)

- GitHub: Add details_url to check_run. (@tmcgilchrist ocurrent/ocurrent#282)

- GitHub: Add Current_github.Api.cmdliner_opt to allow writing
  pipelines which can optionally be run as GitHub apps. (@talex5 ocurrent/ocurrent#281)

- GitHub: Provide markdown details for CheckRun. (@tmcgilchrist ocurrent/ocurrent#288)

- GitHub: Fix wrong name used for repository (@tmcgilchrist ocurrent/ocurrent#289 ocurrent/ocurrent#290)

- GitHub: Support Github rebuild via webooks. (@tmcgilchrist ocurrent/ocurrent#283)

- GitHub: monitor GraphQL queries (@art-w ocurrent/ocurrent#298)

- GitHub: Limit CheckRunStatus summary and text fields to 65535.
  (@tmcgilchrist ocurrent/ocurrent#300)

- GitHub: Log extra context for Webhook validation failure.
  (@tmcgilchrist ocurrent/ocurrent#302)

- GitLab: Initial GitLab plugin work. (@tmcgilchrist ocurrent/ocurrent#299)

- Git: Make git reset less verbose (@kit-ty-kate ocurrent/ocurrent#293)

Web UI:

- Use Lwt.pause instead of Lwt_unix.yield (@MisterDA ocurrent/ocurrent#297)

- Use `ansi` instead of `current_ansi` (@samoht ocurrent/ocurrent#321)

- Show line numbers and allow jumping to specific lines in job
  logs (@punchagan ocurrent/ocurrent#309)

Docker:

- Explicitly set confirmation levels to allow for
  manually triggered jobs. (@tmcgilchrist ocurrent/ocurrent#304)

- Stop using `Dockerfile.t` completely and use strings instead.
  (@MisterDA ocurrent/ocurrent#301 ocurrent/ocurrent#316)

Other:

- Update to cohttp 4.0.0 (ocurrent/ocurrent#274, @talex5)

- Move `Current_incr` to its own repository (ocurrent/ocurrent#284, @talex5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants