opam install . --deps-only comply with the real constraints of packages#6530
Merged
rjbou merged 2 commits intoocaml:masterfrom Jun 5, 2025
Merged
opam install . --deps-only comply with the real constraints of packages#6530rjbou merged 2 commits intoocaml:masterfrom
opam install . --deps-only comply with the real constraints of packages#6530rjbou merged 2 commits intoocaml:masterfrom
Conversation
This was referenced Jun 4, 2025
rjbou
commented
Jun 4, 2025
| of removed system dependencies. Only packages which are unavailable end up | ||
| in this set, they are otherwise put in {!field:reinstall}. *) | ||
|
|
||
| overwrote_opams: (bool * OpamFile.OPAM.t) package_map; |
Collaborator
Author
There was a problem hiding this comment.
The last commit can be removed if we merge #6531 before. To be squashed otherwise
0294522 to
46c4cea
Compare
rjbou
commented
Jun 4, 2025
- reinstall trigger for pin - reinstall trigger for simulated pin (deps-only) - fetch process for simulated pin (deps-only)
…ns when simulating pins
a1432c7 to
13d4fc6
Compare
Member
|
As a side note the same problem also exist elsewhere, such as the build steps, but this new field will make fixing that issue very easy. See #6535 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a package
pkgis already installed andopam install ./pkg --depsis called, if there is a conflict between installedpkgdependencies and localpkgdeclaration, the conflict is not seen and the already installedpkgis kept.For the code itself, the universe given to the solver was retrieving information from the simulated switch state, so the simulated pinned package information, not the good opam definition. We keep then the old information in the switch state, like that we can rearrange the package set given to the solver when creating the universe.
Fix #6529