Skip to content

Fix opam install . --deps updating internal sources and stored opam file#6533

Merged
rjbou merged 4 commits intoocaml:masterfrom
rjbou:fix-simulated-pin-fetching
Jun 5, 2025
Merged

Fix opam install . --deps updating internal sources and stored opam file#6533
rjbou merged 4 commits intoocaml:masterfrom
rjbou:fix-simulated-pin-fetching

Conversation

@rjbou
Copy link
Copy Markdown
Collaborator

@rjbou rjbou commented Jun 4, 2025

During the pinning process, sometimes we don't want to completely repin (in case of an edit for example), so a fetch is done. But it was done even if the pin is simulated.
I've also added some tests to check those fetch cases (from #4542 & #2893's 02d1ea9)

Fix #6532

TODO

  • update API changelog ?

@rjbou rjbou added the KIND: BUG label Jun 4, 2025
@kit-ty-kate kit-ty-kate force-pushed the fix-simulated-pin-fetching branch from 22d2b26 to 4afb61f Compare June 5, 2025 17:11
@kit-ty-kate kit-ty-kate force-pushed the fix-simulated-pin-fetching branch from 4afb61f to 41d6b68 Compare June 5, 2025 18:20
=== remove 1 package
- remove foo-format 2.0 (pinned)
=== recompile 1 package
- recompile foo-core 2.0 (pinned) [uses foo-format]
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: This recompile is a consequence of the previous syncing, that marked foo-core to reinstall.

@rjbou rjbou merged commit b4108d5 into ocaml:master Jun 5, 2025
57 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

opam install . --deps-only updates internaly source and opam file

2 participants