Merged
Conversation
Closed
This allows to specify opam files or project directories to `opam install`, superseding the `opam build` prototype. There are still quite a few rough edges: - `opam install` only: `upgrade`, `reinstall` and `remove` should be supported too (maybe `remove` should unpin as well ?) - Further calls, with a directory as argument, might be expected to sync, i.e. to UNpin packages that were pinned there but don't match anymore (renamed packages ?) ?? - opam file format upgrade missing on pinning, the install re-does the update that was just done
This makes all commands act consistently w.r.t. adding to the roots (specified, newly installed packages are added, unless of course the specific options of `opam install` are used). For example, `opam upgrade foo`, with uninstalled package `foo` and confirmation, correctly adds to the roots. This also changes the behaviour of `opam install` on already installed packages: if the package has pending changes, it will be reinstalled (or upgraded) rather than ignored as it was before.
When computing the universe from OpamSwitchState, rather than later at the solver layer.
ie including format update, aux files etc.
so that possible `opam pin edit` information is not lost.
Member
|
👍 f038997 is my favorite! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to specify opam files or project directories to
opam install,superseding the
opam buildprototype.There are still quite a few rough edges:
opam installonly:upgrade,reinstallandremoveshould be supportedtoo (maybe
removeshould unpin as well ?)Further calls, with a directory as argument, might be expected to sync, i.e.(done)to UNpin packages that were pinned there but don't match anymore (renamed
packages ?) ??
opam file format upgrade missing on pinning, the install re-does the update(fixed)that was just done