Fix simulated pinned packages reinstall trigger#6522
Merged
rjbou merged 1 commit intoocaml:masterfrom Jun 6, 2025
Merged
Conversation
a390d05 to
af29882
Compare
kit-ty-kate
requested changes
May 27, 2025
af29882 to
fbf4fe3
Compare
rjbou
commented
Jun 4, 2025
tests/reftests/simulated-pin.test
Outdated
Comment on lines
+38
to
+41
| === recompile 1 package | ||
| - recompile reinst 1 (pinned) [uses dep-reinst] | ||
| === upgrade 1 package | ||
| - upgrade dep-reinst 1 to 2 [required by reinst] |
Collaborator
Author
There was a problem hiding this comment.
This should be rejected because the dependency constraints from the pinned package and the requested deps are conflicting.
rjbou
commented
Jun 4, 2025
tests/reftests/simulated-pin.test
Outdated
Comment on lines
+34
to
+36
| ### opam install ./reinst --deps-only | ||
| [reinst.1] synchronised (file://${BASEDIR}/reinst) | ||
| [reinst] Installing new package description from upstream file://${BASEDIR}/reinst |
Collaborator
Author
There was a problem hiding this comment.
cf comment #6522 (comment)
Similarly, this should not happen as we are trying to install only the dependency of that package, not the package itself.
This was referenced Jun 4, 2025
The diff was done on already pinned packages only, not newly simulated pinned packages
fbf4fe3 to
227ddb0
Compare
kit-ty-kate
approved these changes
Jun 6, 2025
rjbou
added a commit
to rjbou/opam
that referenced
this pull request
Jun 13, 2025
rjbou
added a commit
to rjbou/opam
that referenced
this pull request
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partial fix of #6501