With --deps-only pkg, no longer set pkg as a conflict#6520
Merged
kit-ty-kate merged 3 commits intoocaml:masterfrom Jun 18, 2025
Merged
With --deps-only pkg, no longer set pkg as a conflict#6520kit-ty-kate merged 3 commits intoocaml:masterfrom
--deps-only pkg, no longer set pkg as a conflict#6520kit-ty-kate merged 3 commits intoocaml:masterfrom
Conversation
--deps-only pkg, no loner set pkg as a conflict--deps-only pkg, no longer set pkg as a conflict
rjbou
commented
May 23, 2025
Comment on lines
+39
to
+42
| === install 3 packages | ||
| - install bar 1 [required by baz] | ||
| - install foo 1 [required by bar, truc] | ||
| - install truc 1 [required by foo] |
Collaborator
Author
There was a problem hiding this comment.
The information here is not very understandable : truc is not a dependency of foo.1, so we don't understand from where it comes.
Should we then add the information of the version to required by pkg messages?
This was referenced Jun 4, 2025
Closed
bd97873 to
f5c7c2d
Compare
Collaborator
Author
|
A double check is needed on the newly added test as it is these tests that we will follow for the futures changes of behaviour of deps-only. |
f5c7c2d to
2976f2e
Compare
kit-ty-kate
approved these changes
Jun 13, 2025
| - install sit 1 [required by lorem] | ||
|
|
||
| <><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><> | ||
| -> removed deps-of-lorem.1 |
Comment on lines
+39
to
+42
| === install 3 packages | ||
| - install bar 1 [required by baz] | ||
| - install foo 1 [required by bar, truc] | ||
| - install truc 1 [required by foo] |
Merged
Install of dependencies (main + tests) from a local package, in the case where the main package is already installed in switch from repository.
Only dependencies are taken into account instead of coinstability of the requested packages
2976f2e to
3ca9578
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behaviour of
opam install --deps-only foocreatesdeps-of-foo.yvirtual packages that contains the dependencies of eachfoo.yand a conflict withfoo != y.This PR changes this behaviour.
It is intended for the case where
foo.1is installed in the switch, and we want to installfoo.2. This leads to the removal offoo.1from the switch even if we don't installfoo.2by itself.related to #6501