Open
Conversation
rjbou
commented
Jun 4, 2025
| ## Config | ||
|
|
||
| ## Pin | ||
| * [BUG] When using `--deps-only`, no longer take into account the simulated pin information. This is hit when a package `pkg` is already installed and `opam install ./pkg --deps` is called, if there is a conflict between installed `pkg` dependencies and local `pkg` declaration, the conflict is not seen and the already installed `pkg` is kept. [#XXX @rjbou] |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| * [BUG] When using `--deps-only`, no longer take into account the simulated pin information. This is hit when a package `pkg` is already installed and `opam install ./pkg --deps` is called, if there is a conflict between installed `pkg` dependencies and local `pkg` declaration, the conflict is not seen and the already installed `pkg` is kept. [#XXX @rjbou] | |
| * [BUG] When using `--deps-only`, no longer take into account the simulated pin information. This is hit when a package `pkg` is already installed and `opam install ./pkg --deps` is called, if there is a conflict between installed `pkg` dependencies and local `pkg` declaration, the conflict is not seen and the already installed `pkg` is kept. [#6531 @rjbou] |
| ## Shell | ||
|
|
||
| ## Internal | ||
| * Cudf: remove unused attribute pinned and installed-roots [#XXX @rjbou] |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| * Cudf: remove unused attribute pinned and installed-roots [#XXX @rjbou] | |
| * Cudf: remove unused attribute pinned and installed-roots [#6531 @rjbou] |
Member
I don't think this is necessary for this PR given it is simply removing something unused. |
Collaborator
Author
The idea is to highlight the change : what was generated and what is now generated. And also, like that in the future, if there is some changes, they can be detected/seen with that test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at #XXX, I found out that there is several attributes given to the solver that are not needed : pinned status and is the package is installed as root. None of the solvers uses that attribute. Digging in the history, I guess that it may have been used before to handle pinned or roots via the solver. These addition date back to the very beginning of opam (#751 for pinned, and ce584b5 -no pr- for installed roots).
I checked locally with opam lib rev deps, nothing broke.
TODO
opam install . --deps-onlycomply with the real constraints of packages #6530, the last two commit are here to revert some changes. If this PR is merged before, they can be removed.