Fixing pinned packages #1: only the pinned version is 'available'#751
Merged
samoht merged 5 commits intoocaml:masterfrom Aug 23, 2013
Merged
Fixing pinned packages #1: only the pinned version is 'available'#751samoht merged 5 commits intoocaml:masterfrom
samoht merged 5 commits intoocaml:masterfrom
Conversation
src/client/opamState.ml
Outdated
Member
There was a problem hiding this comment.
you'll do this for every name.* package. I understand why you do this (because you might want to change the pin version to a non-existent version) but that's quite inefficient especially since you need to re-read the OPAM file every time. Would be nice to to do this only once if possible.
that way, you can change the version in the package's .opam file without breaking everything
(and full-descrs for all of them :p)
samoht
added a commit
that referenced
this pull request
Aug 23, 2013
Fixing pinned packages #1: only the pinned version is 'available'
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.