Skip to content

fix(ctypes): remove unnecessary case changes#6374

Merged
rgrinberg merged 1 commit intomainfrom
ps/rr/fix_ctypes___remove_unnecessary_case_changes
Nov 2, 2022
Merged

fix(ctypes): remove unnecessary case changes#6374
rgrinberg merged 1 commit intomainfrom
ps/rr/fix_ctypes___remove_unnecessary_case_changes

Conversation

@rgrinberg
Copy link
Copy Markdown
Member

@rgrinberg rgrinberg commented Nov 2, 2022

Causes an issue when external_library_name has mixed cases

Signed-off-by: Rudi Grinberg me@rgrinberg.com

@rgrinberg rgrinberg requested a review from mbacarella November 2, 2022 03:15
@rgrinberg rgrinberg added this to the 3.6.0 milestone Nov 2, 2022
@rgrinberg rgrinberg linked an issue Nov 2, 2022 that may be closed by this pull request
@rgrinberg rgrinberg added the c-bindings When dune is trying to interop with C label Nov 2, 2022
Copy link
Copy Markdown
Collaborator

@mbacarella mbacarella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Causes an issue when external_library_name has mixed cases

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

ps-id: 3abe71e7-8d21-43d1-b811-2b1b9e969cdd
@rgrinberg rgrinberg force-pushed the ps/rr/fix_ctypes___remove_unnecessary_case_changes branch from 1f6f0d2 to 0b53433 Compare November 2, 2022 14:39
@rgrinberg rgrinberg merged commit cc0c6fd into main Nov 2, 2022
jchavarri added a commit to jchavarri/dune that referenced this pull request Nov 3, 2022
* main:
  refactor(coq): flatten coqc and coqc_dir into record
  chore: remove melange from CHANGES (ocaml#6378)
  refactor(ctypes): inline some functions (ocaml#6375)
  chore: fix typo in CHANGES (ocaml#6376)
  fix(ctypes): remove unnecessary case changes (ocaml#6374)
  refactor: replace bash with sh (ocaml#6373)
  fix: [Path.Build.to_string_maybe_quoted] (ocaml#6371)
@Alizter Alizter deleted the ps/rr/fix_ctypes___remove_unnecessary_case_changes branch November 12, 2022 15:11
emillon added a commit to emillon/opam-repository that referenced this pull request Nov 14, 2022
…ne-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info, dune-action-plugin and chrome-trace (3.6.0)

CHANGES:

- Forbid multiple instances of dune running concurrently in the same workspace.
  (ocaml/dune#6360, fixes ocaml/dune#236, @rgrinberg)

- Allow promoting into source directories specified by `subdir` (ocaml/dune#6404, fixes
  ocaml/dune#3502, @rgrinberg)

- Make dune describe workspace return the correct root path
  (ocaml/dune#6380, fixes ocaml/dune#6379, @esope)

- Introduce a `$ dune ocaml top-module` subcommand to load modules directly
  without sealing them behind the signature. (ocaml/dune#5940, @rgrinberg)

- [ctypes] do not mangle user written names in the ctypes stanza (ocaml/dune#6374, fixes
  ocaml/dune#5561, @rgrinberg)

- Support `CLICOLOR` and `CLICOLOR_FORCE` to enable/disable/force ANSI
  colors. (ocaml/dune#6340, fixes ocaml/dune#6323, @MisterDA).

- Forbid private libraries with `(package ..)` set from depending on private
  libraries that don't belong to a package (ocaml/dune#6385, fixes ocaml/dune#6153, @rgrinberg)

- Allow `Byte_complete` binaries to be installable (ocaml/dune#4873, @AltGr, @rgrinberg)

- Revive `$ dune external-lib-deps` under `$ dune describe external-lib-deps`.
  (ocaml/dune#6045, @moyodiallo)

- Fix running inline tests in bytecode mode (ocaml/dune#5622, fixes ocaml/dune#5515, @dariusf)

- [ctypes] always re-run `pkg-config` because we aren't tracking its external
  dependencies (ocaml/dune#6052, @rgrinberg)

- [ctypes] remove dependency on configurator in the generated rules (ocaml/dune#6052,
  @rgrinberg)

- Build progress status now shows number of failed jobs (ocaml/dune#6242, @Alizter)

- Allow absolute build directories to find public executables. For example,
  those specified with `(deps %{bin:...})` (ocaml/dune#6326, @anmonteiro)

- Create a fake socket file `_build/.rpc/dune` on windows to allow rpc clients
  to connect using the build directory. (ocaml/dune#6329, @rgrinberg)

- Prevent crash if absolute paths are used in the install stanza and in
  recursive globs. These cases now result in a user error. (ocaml/dune#6331, @gridbugs)

- Add `(glob_files <glob>)` and `(glob_files_rec <glob>)` terms to the `files`
  field of the `install` stanza (ocaml/dune#6250, closes ocaml/dune#6018, @gridbugs)

- Allow `:standard` in the `(modules)` field of the `coq.pp` stanza (ocaml/dune#6229,
  fixes ocaml/dune#2414, @Alizter)

- Fix passing of flags to dune coq top (ocaml/dune#6369, fixes ocaml/dune#6366, @Alizter)

- Extend the promotion CLI to a `dune promotion` group: `dune promote` is moved
  to `dune promotion apply` (the former still works) and the new `dune promotion
  diff` command can be used to just display the promotion without applying it.
  (ocaml/dune#6160, fixes ocaml/dune#5368, @emillon)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c-bindings When dune is trying to interop with C

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when using the ctypes stanza

2 participants