fix: [Path.Build.to_string_maybe_quoted]#6371
Merged
Conversation
this function should match [Path.to_string_maybe_quoted (Path.build p)] Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: 361a98e9-00b4-4e35-afcd-8cf9902dcc0c
df1242d to
b53fca3
Compare
Alizter
approved these changes
Nov 2, 2022
jchavarri
added a commit
to jchavarri/dune
that referenced
this pull request
Nov 3, 2022
* main: refactor(coq): flatten coqc and coqc_dir into record chore: remove melange from CHANGES (ocaml#6378) refactor(ctypes): inline some functions (ocaml#6375) chore: fix typo in CHANGES (ocaml#6376) fix(ctypes): remove unnecessary case changes (ocaml#6374) refactor: replace bash with sh (ocaml#6373) fix: [Path.Build.to_string_maybe_quoted] (ocaml#6371)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this function should match [Path.to_string_maybe_quoted (Path.build p)]
Signed-off-by: Rudi Grinberg me@rgrinberg.com
ps-id: 361a98e9-00b4-4e35-afcd-8cf9902dcc0c