refactor(ctypes): inline some functions#6375
Conversation
they aren't general enough to be useful Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: 841f11b1-5d34-44e4-92c0-03cb571d8790
92b26aa to
f96e519
Compare
|
I found the various stages of ctypes rules generation confusing enough that I thought people coming to it fresh and trying to understand what's going on would be next-level confused. Putting them into separate small top-level named functions was my attempt to discretize and document the steps a bit better. If you think it's just contributing noise I'm happy with inlining them. (I also did some things in an unnecessarily clunky way out of being unfamiliar with better utility functions; improvements there are obviously great) |
|
The problem with wrapping already api's is that it forces the after mentioned potential contributors to learn 2 api's instead of one. At some point, the team decided that all the wrappers that save line of code here and there don't contribute enough and make it more difficult to refactor and learn dune's api. |
* main: refactor(coq): flatten coqc and coqc_dir into record chore: remove melange from CHANGES (ocaml#6378) refactor(ctypes): inline some functions (ocaml#6375) chore: fix typo in CHANGES (ocaml#6376) fix(ctypes): remove unnecessary case changes (ocaml#6374) refactor: replace bash with sh (ocaml#6373) fix: [Path.Build.to_string_maybe_quoted] (ocaml#6371)
they aren't general enough to be useful
Signed-off-by: Rudi Grinberg me@rgrinberg.com