Skip to content

fix: create fake socket rpc file on windows#6329

Merged
rgrinberg merged 1 commit intomainfrom
ps/rr/fix__create_fake_socket_rpc_file_on_windows
Oct 26, 2022
Merged

fix: create fake socket rpc file on windows#6329
rgrinberg merged 1 commit intomainfrom
ps/rr/fix__create_fake_socket_rpc_file_on_windows

Conversation

@rgrinberg
Copy link
Copy Markdown
Member

To allow connections to an rpc instance that isn't in the registry.
Previously, the socket file was only created on Unix. So windows users
couldn't point their clients at _build/.rpc/dune and connect.

Signed-off-by: Rudi Grinberg me@rgrinberg.com

ps-id: c7483b66-9ba3-430e-b5c3-2c3e52a2b1ca

@rgrinberg rgrinberg requested a review from Alizter October 26, 2022 00:38
To allow connections to an rpc instance that isn't in the registry.
Previously, the socket file was only created on Unix. So windows users
couldn't point their clients at _build/.rpc/dune and connect.

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

ps-id: c7483b66-9ba3-430e-b5c3-2c3e52a2b1ca
@rgrinberg rgrinberg force-pushed the ps/rr/fix__create_fake_socket_rpc_file_on_windows branch from df14bbe to 64ba61c Compare October 26, 2022 17:37
@rgrinberg rgrinberg merged commit 6feee83 into main Oct 26, 2022
@Alizter Alizter mentioned this pull request Oct 27, 2022
jchavarri added a commit to jchavarri/dune that referenced this pull request Oct 27, 2022
* main:
  makefile: bind on 0.0.0.0 for livedoc (ocaml#6336)
  ci: rewrite fmt job (ocaml#6334)
  refactor(ci): cleanup names (ocaml#6335)
  fix: create fake socket rpc file on windows (ocaml#6329)
  refactor(doc): improvements to hacking.rst (ocaml#6324)
  ci: Add documentation job (ocaml#6333)
  Fix bug in drop_suffix (ocaml#6321)
  fix: public binaries with absolute build path
  test: public binaries in a cram test
  chore: update dune-project to 3.5 (ocaml#6328)
  chore(nix): add `devShells.slim` (ocaml#6327)
  test: remove obsolete bisect tests (ocaml#6318)
  refactor: clarify matching for path comparison and add a docstring (ocaml#6322)
@Alizter Alizter deleted the ps/rr/fix__create_fake_socket_rpc_file_on_windows branch November 12, 2022 15:12
emillon added a commit to emillon/opam-repository that referenced this pull request Nov 14, 2022
…ne-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info, dune-action-plugin and chrome-trace (3.6.0)

CHANGES:

- Forbid multiple instances of dune running concurrently in the same workspace.
  (ocaml/dune#6360, fixes ocaml/dune#236, @rgrinberg)

- Allow promoting into source directories specified by `subdir` (ocaml/dune#6404, fixes
  ocaml/dune#3502, @rgrinberg)

- Make dune describe workspace return the correct root path
  (ocaml/dune#6380, fixes ocaml/dune#6379, @esope)

- Introduce a `$ dune ocaml top-module` subcommand to load modules directly
  without sealing them behind the signature. (ocaml/dune#5940, @rgrinberg)

- [ctypes] do not mangle user written names in the ctypes stanza (ocaml/dune#6374, fixes
  ocaml/dune#5561, @rgrinberg)

- Support `CLICOLOR` and `CLICOLOR_FORCE` to enable/disable/force ANSI
  colors. (ocaml/dune#6340, fixes ocaml/dune#6323, @MisterDA).

- Forbid private libraries with `(package ..)` set from depending on private
  libraries that don't belong to a package (ocaml/dune#6385, fixes ocaml/dune#6153, @rgrinberg)

- Allow `Byte_complete` binaries to be installable (ocaml/dune#4873, @AltGr, @rgrinberg)

- Revive `$ dune external-lib-deps` under `$ dune describe external-lib-deps`.
  (ocaml/dune#6045, @moyodiallo)

- Fix running inline tests in bytecode mode (ocaml/dune#5622, fixes ocaml/dune#5515, @dariusf)

- [ctypes] always re-run `pkg-config` because we aren't tracking its external
  dependencies (ocaml/dune#6052, @rgrinberg)

- [ctypes] remove dependency on configurator in the generated rules (ocaml/dune#6052,
  @rgrinberg)

- Build progress status now shows number of failed jobs (ocaml/dune#6242, @Alizter)

- Allow absolute build directories to find public executables. For example,
  those specified with `(deps %{bin:...})` (ocaml/dune#6326, @anmonteiro)

- Create a fake socket file `_build/.rpc/dune` on windows to allow rpc clients
  to connect using the build directory. (ocaml/dune#6329, @rgrinberg)

- Prevent crash if absolute paths are used in the install stanza and in
  recursive globs. These cases now result in a user error. (ocaml/dune#6331, @gridbugs)

- Add `(glob_files <glob>)` and `(glob_files_rec <glob>)` terms to the `files`
  field of the `install` stanza (ocaml/dune#6250, closes ocaml/dune#6018, @gridbugs)

- Allow `:standard` in the `(modules)` field of the `coq.pp` stanza (ocaml/dune#6229,
  fixes ocaml/dune#2414, @Alizter)

- Fix passing of flags to dune coq top (ocaml/dune#6369, fixes ocaml/dune#6366, @Alizter)

- Extend the promotion CLI to a `dune promotion` group: `dune promote` is moved
  to `dune promotion apply` (the former still works) and the new `dune promotion
  diff` command can be used to just display the promotion without applying it.
  (ocaml/dune#6160, fixes ocaml/dune#5368, @emillon)
@rgrinberg rgrinberg added the windows Issues that relate to Dune on Microsoft Windows label Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

windows Issues that relate to Dune on Microsoft Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants