Merged
Conversation
rgrinberg
reviewed
Oct 25, 2022
flake.nix
Outdated
|
|
||
| devShells.slim = with pkgs.ocamlPackages; pkgs.mkShell { | ||
| inputsFrom = [ dune_3 ]; | ||
| buildInputs = [ merlin ]; |
Member
There was a problem hiding this comment.
Wouldn't this be a bit more useful if you included some of the deps needed to run the unit tests? At least ppx_expect for example.
Collaborator
Author
There was a problem hiding this comment.
good point. added some of the test inputs that gets make test further
Add a lighter version of the default shell that can bootstrap an environment with `nix develop .#slim` Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
fd5d5ee to
7d100d5
Compare
rgrinberg
reviewed
Oct 25, 2022
| cinaps | ||
| menhir | ||
| odoc | ||
| lwt |
Member
There was a problem hiding this comment.
I guess this is only needed because dune-rpc-lwt isn't it in nixpkgs?
Collaborator
Author
There was a problem hiding this comment.
I suppose that's the case. make test requests it:
File "otherlibs/dune-rpc-lwt/test/dune", line 17, characters 2-10:
17 | lwt.unix
^^^^^^^^
Error: Library "lwt.unix" not found.
-> required by library "dune_rpc_lwt_tests" in
_build/default/otherlibs/dune-rpc-lwt/test
-> required by
_build/default/otherlibs/dune-rpc-lwt/test/.dune_rpc_lwt_tests.inline-tests/inline_test_runner_dune_rpc_lwt_tests.exe
-> required by alias otherlibs/dune-rpc-lwt/test/runtest in
otherlibs/dune-rpc-lwt/test/dune:3
Member
There was a problem hiding this comment.
Yeah, in the future it would be nice to get inputsFrom from all the packages in the repo.
Closed
jchavarri
added a commit
to jchavarri/dune
that referenced
this pull request
Oct 27, 2022
* main: makefile: bind on 0.0.0.0 for livedoc (ocaml#6336) ci: rewrite fmt job (ocaml#6334) refactor(ci): cleanup names (ocaml#6335) fix: create fake socket rpc file on windows (ocaml#6329) refactor(doc): improvements to hacking.rst (ocaml#6324) ci: Add documentation job (ocaml#6333) Fix bug in drop_suffix (ocaml#6321) fix: public binaries with absolute build path test: public binaries in a cram test chore: update dune-project to 3.5 (ocaml#6328) chore(nix): add `devShells.slim` (ocaml#6327) test: remove obsolete bisect tests (ocaml#6318) refactor: clarify matching for path comparison and add a docstring (ocaml#6322)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nix develop .#slimSigned-off-by: Antonio Nuno Monteiro anmonteiro@gmail.com