refactor(doc): improvements to hacking.rst#6324
Merged
rgrinberg merged 1 commit intoocaml:mainfrom Oct 26, 2022
Merged
Conversation
Alizter
commented
Oct 25, 2022
rgrinberg
reviewed
Oct 25, 2022
854c24f to
fec9a00
Compare
christinerose
approved these changes
Oct 26, 2022
Contributor
christinerose
left a comment
There was a problem hiding this comment.
Some minor suggestions in formatting/grammar, but I'm approving it so you don't have to wait on me to approve before merging. 😄
76f0fb4 to
f07fdad
Compare
I have: - Made sure line wrapping is consistent. - Added a table of contents. - Added information about Nix environements for devs. Signed-off-by: Ali Caglayan <alizter@gmail.com> ps-id: 62c2ddba-2c34-4458-a31c-47f11f338760
f07fdad to
6c64a0c
Compare
rgrinberg
approved these changes
Oct 26, 2022
Closed
jchavarri
added a commit
to jchavarri/dune
that referenced
this pull request
Oct 27, 2022
* main: makefile: bind on 0.0.0.0 for livedoc (ocaml#6336) ci: rewrite fmt job (ocaml#6334) refactor(ci): cleanup names (ocaml#6335) fix: create fake socket rpc file on windows (ocaml#6329) refactor(doc): improvements to hacking.rst (ocaml#6324) ci: Add documentation job (ocaml#6333) Fix bug in drop_suffix (ocaml#6321) fix: public binaries with absolute build path test: public binaries in a cram test chore: update dune-project to 3.5 (ocaml#6328) chore(nix): add `devShells.slim` (ocaml#6327) test: remove obsolete bisect tests (ocaml#6318) refactor: clarify matching for path comparison and add a docstring (ocaml#6322)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have: