Add SysListView32 to isBadUIAWindow, fix task manager freeze#15519
Merged
Conversation
michaelDCurran
previously approved these changes
Sep 26, 2023
5 tasks
seanbudd
pushed a commit
that referenced
this pull request
Oct 1, 2023
Related to #6245 and #15519 Summary of the issue: Change log contains an incorrect item Fixed performance issues with Task Manager and some Windows versions. (#6245) Indeed #6245. It had been erroneously closed as duplicate of #15519 before being reopened again. Indeed, #15519 is about tagging the task list as bad UIA window, whereas #6245 was already an issue before trying to consider the task list as good UIA window. Description of user facing changes Remove the incorrect log entry
CyrilleB79
added a commit
to CyrilleB79/nvda
that referenced
this pull request
Oct 2, 2023
Related to nvaccess#6245 and nvaccess#15519 Summary of the issue: Change log contains an incorrect item Fixed performance issues with Task Manager and some Windows versions. (nvaccess#6245) Indeed nvaccess#6245. It had been erroneously closed as duplicate of nvaccess#15519 before being reopened again. Indeed, nvaccess#15519 is about tagging the task list as bad UIA window, whereas nvaccess#6245 was already an issue before trying to consider the task list as good UIA window. Description of user facing changes Remove the incorrect log entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15503
Fixes #6245
Summary of the issue:
NVDA is extremely slow to respond in this Task Manager task list. This is due to UIA being a bad implementation.
Description of user facing changes
Task manager should now have better performance in some versions of Windows.
Description of development approach
Mark sysListView32 as a badUIAWindow for the task manager app module.
Similar to #15348
Testing strategy:
Requires alpha/beta testing from reporters
Known issues with pull request:
None
Code Review Checklist: