Skip to content

Remove incorrect change log item#15552

Merged
seanbudd merged 1 commit into
nvaccess:betafrom
CyrilleB79:chgLog
Oct 1, 2023
Merged

Remove incorrect change log item#15552
seanbudd merged 1 commit into
nvaccess:betafrom
CyrilleB79:chgLog

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

Related to #6245 and #15519

Summary of the issue:

Change log contains an incorrect item
Fixed performance issues with Task Manager and some Windows versions. (#6245)

Indeed #6245. It had been erroneously closed as duplicate of #15519 before being reopened again. Indeed, #15519 is about tagging the task list as bad UIA window, whereas #6245 was already an issue before trying to consider the task list as good UIA window.

Description of user facing changes

Remove the incorrect log entry

Description of development approach

N/A

Testing strategy:

N/A

Known issues with pull request:

None

Note

We always need to be very careful when reopening a closed issue with a milestone or when reverting PRs/

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review September 29, 2023 12:38
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner September 29, 2023 12:38
@CyrilleB79 CyrilleB79 requested review from seanbudd and removed request for a team September 29, 2023 12:38

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

@seanbudd seanbudd merged commit 5484a66 into nvaccess:beta Oct 1, 2023
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Oct 1, 2023
@seanbudd seanbudd modified the milestones: 2024.1, 2023.3 Oct 1, 2023
CyrilleB79 added a commit to CyrilleB79/nvda that referenced this pull request Oct 2, 2023
Related to nvaccess#6245 and nvaccess#15519

Summary of the issue:
Change log contains an incorrect item
Fixed performance issues with Task Manager and some Windows versions. (nvaccess#6245)

Indeed nvaccess#6245. It had been erroneously closed as duplicate of nvaccess#15519 before being reopened again. Indeed, nvaccess#15519 is about tagging the task list as bad UIA window, whereas nvaccess#6245 was already an issue before trying to consider the task list as good UIA window.

Description of user facing changes
Remove the incorrect log entry
@CyrilleB79 CyrilleB79 deleted the chgLog branch October 2, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants