Skip to content

Mark SysListView32 as bad for UIA in mmc#15348

Merged
seanbudd merged 4 commits into
nvaccess:masterfrom
LeonarddeR:revertSysListView
Aug 31, 2023
Merged

Mark SysListView32 as bad for UIA in mmc#15348
seanbudd merged 4 commits into
nvaccess:masterfrom
LeonarddeR:revertSysListView

Conversation

@LeonarddeR

@LeonarddeR LeonarddeR commented Aug 30, 2023 •
edited by seanbudd
Loading

Copy link
Copy Markdown
Collaborator

Link to issue number:

Fixes #15333

Summary of the issue:

In #15295, we removed SysListView32 as a bad UIA class name as there are now decent UIA implementations that should be prefered over their MSAA counterparts. However, it turns out that Windows Management Console, despite advertising a native UIA implementation, offers something quite incomplete.

Description of user facing changes

Working list navigation in mmc, such as in windows Services list

Description of development approach

  1. Classify SysListView32 as Bad UIA class in the mmc app module. Note. I have also tested several other applications in Windows, including regedit, and there no UIA implementation of SysListView32 is advertised. Therefore I think this might be a onetimer.
  2. Ensures that whenever UIA is used wit an incomplete implementation, no errors occur by performing the necessary checks.

Testing strategy:

Tested the services list with and without mmc appModule change.

Known issues with pull request:

None known

Change log entries:

None needed.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@LeonarddeR LeonarddeR requested a review from a team as a code owner August 30, 2023 17:50
@LeonarddeR LeonarddeR requested a review from seanbudd August 30, 2023 17:50
@AppVeyorBot

AppVeyorBot commented Aug 30, 2023

Copy link
Copy Markdown

See test results for failed build of commit 81578bb0de

@XLTechie

XLTechie commented Aug 30, 2023 via email

Copy link
Copy Markdown
Collaborator

seanbudd
seanbudd approved these changes Aug 30, 2023
View reviewed changes

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LeonarddeR

@seanbudd

seanbudd commented Aug 30, 2023

Copy link
Copy Markdown
Member

I've fixed this @XLTechie

@seanbudd

seanbudd commented Aug 30, 2023

Copy link
Copy Markdown
Member

Could you please fix up the lint check? from logHandler import log is missing

@CyrilleB79 CyrilleB79 mentioned this pull request Aug 31, 2023
Closed
@seanbudd seanbudd merged commit ba9215c into nvaccess:master Aug 31, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.3 milestone Aug 31, 2023
@seanbudd seanbudd mentioned this pull request Sep 26, 2023
Merged
5 tasks
seanbudd added a commit that referenced this pull request Sep 26, 2023
@seanbudd
Add SysListView32 to isBadUIAWindow, fix task manager freeze (#15519)
da4e3a2 
Fixes #15503
Fixes #6245

Summary of the issue:
NVDA is extremely slow to respond in this Task Manager task list. This is due to UIA being a bad implementation.

Description of user facing changes
Task manager should now have better performance in some versions of Windows.

Description of development approach
Mark sysListView32 as a badUIAWindow for the task manager app module.
Similar to #15348
@LeonarddeR LeonarddeR deleted the revertSysListView branch August 23, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2023.3

Development

Successfully merging this pull request may close these issues.

Unable to access some list of Windows components

5 participants

@LeonarddeR @AppVeyorBot @XLTechie @seanbudd @nvaccessAuto