Eurobraille bnote and bbook automatic detection#14690
Conversation
See test results for failed build of commit 901eae92bc |
See test results for failed build of commit b7714634ce |
LeonarddeR
left a comment
There was a problem hiding this comment.
Instead of using a different gesture map for the note to change gestures, it should be possible to use model based identifiers. Those take precedence over the generic ones. That means adding only two new joystick identifiers for the note displays in the format br(eurobraille.b.note). Both translate to the same model identifier according to self.model = display.deviceType.lower().split(" ")[0]
See test results for failed build of commit a55cfcf924 |
See test results for failed build of commit 456c31ca91 |
See test results for failed build of commit 6dea777dfa |
|
I am not sure why appveyor failed the symbols tests. All symbol tests failed because of "Speech did not finish before timeout" |
|
Probably not linked to braille drivers. System tests sometimes are not very stable. You may want to push a new commit to run tests again to have them passed, e.g.: |
See test results for failed build of commit cbdbdd5bbd |
|
Is this ready for review? The test failures are irrelevant here |
|
Hi @seanbudd, this is ready for review in that case. |
seanbudd
left a comment
There was a problem hiding this comment.
This generally looks good to me.
Let me know your thoughts on splitting the files.
|
Thanks for the corrections @seanbudd .I have missed the formatting rules of the user guide. |
See test results for failed build of commit 243e085211 |
seanbudd
left a comment
There was a problem hiding this comment.
Hi @FalkoBabbage ,
I've pushed some changes fixing up the key formatting in the user guide.
Can you please review and make sure I didn't mess anything up?
Notably:
- removing a group of keys that was repeated 3 times
- changed to using
lowerCamelCaseconsistently for keys, to match the rest of the user guide - using code formatting for entire key sequence, e.g.
``dot1+space``, notdot1+``space``
| | Scroll braille display back | backward | | ||
| | Scroll braille display forward | Forward | | ||
| | Move to current focus | Backward + forward | | ||
| | Route to braille cell | routing | | ||
| | Scroll braille display back | backward | | ||
| | Scroll braille display forward | Forward | | ||
| | Move to current focus | Backward + forward | | ||
| | Route to braille cell | routing | | ||
| | Scroll braille display back | backward | | ||
| | Scroll braille display forward | Forward | | ||
| | Move to current focus | Backward + forward | | ||
| | Route to braille cell | routing | |
There was a problem hiding this comment.
these are duplicated three times, is there a reason for it?
There was a problem hiding this comment.
That's a mistake I made while copying the provided documentation from Eurobraille to the t2t format. Thank you for noticing it!
seanbudd
left a comment
There was a problem hiding this comment.
Hi @FalkoBabbage ,
I've pushed some changes fixing up the key formatting in the user guide.
Can you please review and make sure I didn't mess anything up?
Notably:
- removing a group of keys that was repeated 3 times
- changed to using
lowerCamelCaseconsistently for keys, to match the rest of the user guide - using code formatting for entire key sequence, e.g.
``dot1+space``, notdot1+``space``
|
Could you also please fix the linting issues raised in the PR failure message? |
See test results for failed build of commit dabd96a102 |
Thank you! I went through the documentation and it is correct now. |
See test results for failed build of commit 58662ec369 |
|
@FalkoBabbage - there is a standards file here: https://github.com/nvaccess/nvda/blob/master/devDocs/userGuideStandards.md |
Follow up to #14690 Summary of the issue: The docs for the eurobraille display aren't entirely clear and could use some rewording Description of user facing changes Fix up docs
None Fix-up of #14690 Summary of the issue: In input help mode, when pressing a dot key on the braille keyboard of Esys, I get the following in the log: INFO - inputCore.InputManager._handleInputHelp (11:32:45.222) - MainThread (15120): Input help: gesture br(eurobraille.esys):d+o+t+<+g+e+n+e+r+a+t+o+r+ +o+b+j+e+c+t+ +I+n+p+u+t+G+e+s+t+u+r+e+.+_+_+i+n+i+t+_+_+.+<+l+o+c+a+l+s+>+.+<+g+e+n+e+x+p+r+>+ +a+t+ +0+x+0+8+A+2+9+9+F+0+>, bound to script braille_dots on globalCommands.GlobalCommands Description of user facing changes Fixed the logged message Description of development approach Small fix in code (see diff)
Fix-up for #14690 Summary of the issue: f-string was written as "f ...." instead of f"...."
Eurobraille asked us to adjust the current braille display driver in NVDA. This includes the automatic detection of 2 devices as well as some changes in the gestures.
Link to issue number:
Not applicable
Summary of the issue:
Description of user facing changes
Description of development approach
Testing strategy:
Known issues with pull request:
Change log entries:
New features
Changes
Bug fixes
For Developers
Code Review Checklist: