Skip to content

Fixed mistake in f-string Eurobraille#15203

Merged
seanbudd merged 1 commit into
nvaccess:betafrom
FalkoBabbage:euroBrailleLog
Jul 31, 2023
Merged

Fixed mistake in f-string Eurobraille#15203
seanbudd merged 1 commit into
nvaccess:betafrom
FalkoBabbage:euroBrailleLog

Conversation

@FalkoBabbage

@FalkoBabbage FalkoBabbage commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

Link to issue number:

Fix-up for #14690

Summary of the issue:

f-string was written as "f ...." instead of f"...."

Description of user facing changes

Description of development approach

Testing strategy:

None

Known issues with pull request:

Change log entries:

New features
Changes
Bug fixes
For Developers

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@FalkoBabbage FalkoBabbage requested a review from a team as a code owner July 27, 2023 11:28
@FalkoBabbage FalkoBabbage requested a review from seanbudd July 27, 2023 11:28
@seanbudd

seanbudd commented Jul 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Could you please rebase this on beta, and make this target beta instead?
I think it would be good to include this in beta in case there are related issues with the device and a log with data would be helpful

@seanbudd seanbudd added this to the 2023.2 milestone Jul 28, 2023
@seanbudd seanbudd changed the base branch from master to beta July 28, 2023 06:45
@seanbudd seanbudd requested a review from a team as a code owner July 28, 2023 06:45
@seanbudd seanbudd requested review from Qchristensen and removed request for a team July 28, 2023 06:45
@FalkoBabbage

FalkoBabbage commented Jul 28, 2023

Copy link
Copy Markdown
Contributor Author

Hi @seanbudd,
Looks like you already rebased it? I am not sure why there are 8 commits related to this pr.

@seanbudd

seanbudd commented Jul 29, 2023

Copy link
Copy Markdown
Member

I retargeted the PR to beta. The other commits are because your commit is based on master.

These are commits from master that we don't want on our beta branch.

To rebase a commit, you can follow this guide
https://git-scm.com/book/en/v2/Git-Branching-Rebasing

@seanbudd

seanbudd commented Jul 29, 2023

Copy link
Copy Markdown
Member

Apologies, that guide is not particularly accessible.

I'm not sure if anyone has suggestions on a non-visual guide to git rebases?

@seanbudd

seanbudd commented Jul 31, 2023

Copy link
Copy Markdown
Member

for reference I performed git rebase -i beta

@seanbudd seanbudd merged commit 67826f4 into nvaccess:beta Jul 31, 2023
@FalkoBabbage

FalkoBabbage commented Jul 31, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @seanbudd, I tried preforming git rebase beta but it seemed I made a greater mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd Awaiting requested review from seanbudd seanbudd is a code owner automatically assigned from nvaccess/developers

@Qchristensen Qchristensen Awaiting requested review from Qchristensen Qchristensen was automatically assigned from nvaccess/userdocs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2023.2

Development

Successfully merging this pull request may close these issues.

2 participants

@FalkoBabbage @seanbudd