Fix for Eurobraille gesture logging during input help#15201
Merged
Conversation
LeonarddeR
reviewed
Jul 27, 2023
Contributor
|
Fix looks good! I guess I made a mistake when copy/pasting the code to separate files, my IDE can be quite annoying :) . |
See test results for failed build of commit 815b9eb320 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Fix-up of #14690
Summary of the issue:
In input help mode, when pressing a dot key on the braille keyboard of Esys, I get the following in the log:
Description of user facing changes
Fixed the logged message
Description of development approach
Small fix in code (see diff)
Testing strategy:
Checked the log when pressing dot key:
Known issues with pull request:
None
Change log entries:
Not needed, fixing an unreleased (and minor) bug.
Code Review Checklist:
Note
I am not used to braille code at all; @FalkoBabbage or @LeonarddeR you may want to check it (even if the fix is small).