Skip to content

Fix for Eurobraille gesture logging during input help#15201

Merged
seanbudd merged 2 commits into
nvaccess:betafrom
CyrilleB79:brailleLog
Jul 28, 2023
Merged

Fix for Eurobraille gesture logging during input help#15201
seanbudd merged 2 commits into
nvaccess:betafrom
CyrilleB79:brailleLog

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

None
Fix-up of #14690

Summary of the issue:

In input help mode, when pressing a dot key on the braille keyboard of Esys, I get the following in the log:

INFO - inputCore.InputManager._handleInputHelp (11:32:45.222) - MainThread (15120):
Input help: gesture br(eurobraille.esys):d+o+t+<+g+e+n+e+r+a+t+o+r+ +o+b+j+e+c+t+ +I+n+p+u+t+G+e+s+t+u+r+e+.+_+_+i+n+i+t+_+_+.+<+l+o+c+a+l+s+>+.+<+g+e+n+e+x+p+r+>+ +a+t+ +0+x+0+8+A+2+9+9+F+0+>, bound to script braille_dots on globalCommands.GlobalCommands

Description of user facing changes

Fixed the logged message

Description of development approach

Small fix in code (see diff)

Testing strategy:

Checked the log when pressing dot key:

INFO - inputCore.InputManager._handleInputHelp (11:31:48.871) - MainThread (6896):
Input help: gesture br(eurobraille.esys):dot5, bound to script braille_dots on globalCommands.GlobalCommands

Known issues with pull request:

None

Change log entries:

Not needed, fixing an unreleased (and minor) bug.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

Note

I am not used to braille code at all; @FalkoBabbage or @LeonarddeR you may want to check it (even if the fix is small).

Comment thread user_docs/en/userGuide.t2t Outdated
@FalkoBabbage

Copy link
Copy Markdown
Contributor

Fix looks good! I guess I made a mistake when copy/pasting the code to separate files, my IDE can be quite annoying :) .

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 815b9eb320

@CyrilleB79 CyrilleB79 marked this pull request as ready for review July 27, 2023 13:07
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner July 27, 2023 13:07
@CyrilleB79 CyrilleB79 requested review from seanbudd and removed request for a team July 27, 2023 13:07

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

@seanbudd seanbudd merged commit 364d029 into nvaccess:beta Jul 28, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.3 milestone Jul 28, 2023
@seanbudd seanbudd modified the milestones: 2023.3, 2023.2 Jul 28, 2023
@CyrilleB79 CyrilleB79 deleted the brailleLog branch August 29, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants