Skip to content

Forcibly include brailleDisplayDrivers.eurobraille in packages#15090

Merged
seanbudd merged 1 commit into
masterfrom
exposeEuroBraille
Jul 3, 2023
Merged

Forcibly include brailleDisplayDrivers.eurobraille in packages#15090
seanbudd merged 1 commit into
masterfrom
exposeEuroBraille

Conversation

@seanbudd

@seanbudd seanbudd commented Jul 3, 2023

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #15079

Summary of the issue:

Eurobraille devices were not being detected as of #14690

Description of user facing changes

Eurobraille devices should now be detected

Description of development approach

Forcibly include brailleDisplayDrivers.eurobraille in packages like the albatross driver

Testing strategy:

Known issues with pull request:

None

Change log entries:

N/A, regression

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner July 3, 2023 03:20
@seanbudd seanbudd requested a review from michaelDCurran July 3, 2023 03:20
@seanbudd seanbudd merged commit 5d1b0e8 into master Jul 3, 2023
@seanbudd seanbudd deleted the exposeEuroBraille branch July 3, 2023 06:35
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jul 3, 2023
@CyrilleB79

Copy link
Copy Markdown
Contributor

Just confirming on my side on last alpha snapshot (nvda_snapshot_alpha-28584,5c4e6e1f.exe) that the Esys80 braille display is detected again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No braille with Esys80 on last alpha

4 participants