Skip to content

fix 8 uninitialized reads#180

Closed
ariccio wants to merge 1 commit intonotepad-plus-plus:masterfrom
ariccio:fix-uninitialized-reads
Closed

fix 8 uninitialized reads#180
ariccio wants to merge 1 commit intonotepad-plus-plus:masterfrom
ariccio:fix-uninitialized-reads

Conversation

@ariccio
Copy link
Contributor

@ariccio ariccio commented Jun 11, 2015

Fixing 8 uninitialized reads, in the same spirit as #146, #145, #144, and #138.

@Eldaw
Copy link

Eldaw commented Jun 12, 2015

ariccio, it sounds to me like you are a skilled developer. However, I must say that I (as someone who is not a C++ developer) do wonder why you choose to contribute only changes that relate to the technical correctness of the code.

On this project's growing Issues list are quite a number of small usability bugs and usability enhancement requests. I bet that some of them could be quickly implemented with just a couple of lines of code and make a big difference to the experience of using the application.

All I'm saying is I wonder if it wouldn't be a better use of your expertise to knock some of those out.

@MAPJe71
Copy link
Contributor

MAPJe71 commented Jun 12, 2015

@Eldaw the technical incorrectness of the code could easily be the cause for some of the bugs.

@Eldaw
Copy link

Eldaw commented Jun 12, 2015

@MAPJe71 Yes, I agree with you. Do you think it would make sense to specifically target some of the reported bugs, usability enhancements, and functional enhancements, and at the same time make sure that the introduced code is technically correct? Rather than only making general changes which might also end up making some of the reported issues stale/obsolete as a side effect, but might not.

@MAPJe71
Copy link
Contributor

MAPJe71 commented Jun 12, 2015

First of all, any introduced code should be technically correct!
Second, addressing the technical incorrectness of the code should not depend on addressing reported bugs, usability enhancements, and functional enhancements solely.

@donho
Copy link
Member

donho commented Jun 12, 2015

@Eldaw I couldn't agree more.
@ariccio Unless you wanna do some bug-fixes or add some new features, don't waste your time here.
As I mentioned in https://github.com/notepad-plus-plus/notepad-plus-plus/blob/master/CONTRIBUTING.md :
"Only bug-fix and feature request will be accepted. For the other things, I can run static code analysis tool myself."

For the technical incorrectness in the code, I will do the fixes myself.

@donho donho closed this Jun 12, 2015
@ariccio
Copy link
Contributor Author

ariccio commented Jun 12, 2015

Shouldn't you pass the size of target string str to _tcscat_s as second argument?

Template parameter inference is a pretty cool thing.

@MAPJe71
Copy link
Contributor

MAPJe71 commented Jun 12, 2015

Hmm, missed that one and yes it is.

@ariccio
Copy link
Contributor Author

ariccio commented Jun 13, 2015

Unless you wanna do some bug-fixes or add some new features, don't waste your time here.

I assumed, because #146, #145, #144, and #138, were all merged, that this was an acceptable change. I'll have to dig through some bug reports...

@ariccio ariccio deleted the fix-uninitialized-reads branch June 13, 2015 04:21
This was referenced Jun 18, 2015
Closed
Merged
@ariccio
Copy link
Contributor Author

ariccio commented Jun 24, 2015

Meanwhile, an uninitialized read fix has been accepted in 223caa2 .

@ariccio ariccio mentioned this pull request Jun 24, 2015
Closed
@milipili milipili modified the milestone: 6.x Jun 29, 2015
@ariccio ariccio mentioned this pull request Jun 30, 2015
Closed
@ariccio ariccio mentioned this pull request Jul 16, 2015
Closed
chcg added a commit to chcg/notepad-plus-plus that referenced this pull request Jul 27, 2023
@chcg
Update: Scintilla 5.3.6 and Lexilla 5.2.6
33fb85a 
update to Scinitlla Release 5.3.6 (https://www.scintilla.org/scintilla536.zip)

    Released 26 July 2023.
    Redraw calltip after showing as didn't update when size of new text exactly same as previous. Feature notepad-plus-plus#1486.
    On Win32 fix reverse arrow cursor when scaled. Bug notepad-plus-plus#2382.
    On Win32 hide cursor when typing if that system preference has been chosen. Bug notepad-plus-plus#2333.
    On Win32 and Qt, stop aligning IME candidate window to target. It is now always aligned to start of composition string. This undoes part of feature notepad-plus-plus#1300. Feature notepad-plus-plus#1488, Bug notepad-plus-plus#2391, Feature notepad-plus-plus#1300.
    On Qt, for IMEs, update micro focus when selection changes. This may move the location of IME popups to align with the caret.
    On Qt, implement replacement for IMEs which may help with actions like reconversion. This is similar to delete-surrounding on GTK.

and Lexilla Release 5.2.6 (https://www.scintilla.org/lexilla526.zip)

    Released 26 July 2023.
    Include empty word list names in value returned by DescribeWordListSets and SCI_DESCRIBEKEYWORDSETS. Issue notepad-plus-plus#175, Pull request notepad-plus-plus#176.
    Bash: style here-doc end delimiters as SCE_SH_HERE_DELIM instead of SCE_SH_HERE_Q. Issue notepad-plus-plus#177.
    Bash: allow '$' as last character in string. Issue notepad-plus-plus#180, Pull request notepad-plus-plus#181.
    Bash: fix state after expansion. Highlight all numeric and file test operators. Don't highlight dash in long option as operator. Issue notepad-plus-plus#182, Pull request notepad-plus-plus#183.
    Bash: strict checking of special parameters ($*, $@, $$, ...) with property lexer.bash.special.parameter to specify valid parameters. Issue notepad-plus-plus#184, Pull request notepad-plus-plus#186.
    Bash: recognize keyword before redirection operators (< and >). Issue notepad-plus-plus#188, Pull request notepad-plus-plus#189.
    Errorlist: recognize Bash diagnostic messages.
    HTML: allow ASP block to terminate inside line comment. Issue notepad-plus-plus#185.
    HTML: fix folding with JSP/ASP.NET <%-- comment. Issue notepad-plus-plus#191.
    HTML: fix incremental styling of multi-line ASP.NET directive. Issue notepad-plus-plus#191.
    Matlab: improve arguments blocks. Add support for multiple arguments blocks. Prevent "arguments" from being keyword in function declaration line. Fix semicolon handling. Pull request notepad-plus-plus#179.
    Visual Prolog: add support for embedded syntax with SCE_VISUALPROLOG_EMBEDDED and SCE_VISUALPROLOG_PLACEHOLDER.
    Styling of string literals changed with no differentiation between literals with quotes and those that are prefixed with "@". Quote characters are in a separate style (SCE_VISUALPROLOG_STRING_QUOTE) to contents (SCE_VISUALPROLOG_STRING).
    SCE_VISUALPROLOG_CHARACTER, SCE_VISUALPROLOG_CHARACTER_TOO_MANY, SCE_VISUALPROLOG_CHARACTER_ESCAPE_ERROR, SCE_VISUALPROLOG_STRING_EOL_OPEN, and SCE_VISUALPROLOG_STRING_VERBATIM_SPECIAL were removed (replaced with SCE_VISUALPROLOG_UNUSED[1-5]). Pull request notepad-plus-plus#178.
donho pushed a commit to donho/notepad-plus-plus that referenced this pull request Aug 1, 2023
@chcg @donho
Update: Scintilla 5.3.6 and Lexilla 5.2.6
cc1a3c8 
update to Scinitlla Release 5.3.6 (https://www.scintilla.org/scintilla536.zip)

    Released 26 July 2023.
    Redraw calltip after showing as didn't update when size of new text exactly same as previous. Feature notepad-plus-plus#1486.
    On Win32 fix reverse arrow cursor when scaled. Bug notepad-plus-plus#2382.
    On Win32 hide cursor when typing if that system preference has been chosen. Bug notepad-plus-plus#2333.
    On Win32 and Qt, stop aligning IME candidate window to target. It is now always aligned to start of composition string. This undoes part of feature notepad-plus-plus#1300. Feature notepad-plus-plus#1488, Bug notepad-plus-plus#2391, Feature notepad-plus-plus#1300.
    On Qt, for IMEs, update micro focus when selection changes. This may move the location of IME popups to align with the caret.
    On Qt, implement replacement for IMEs which may help with actions like reconversion. This is similar to delete-surrounding on GTK.

and Lexilla Release 5.2.6 (https://www.scintilla.org/lexilla526.zip)

    Released 26 July 2023.
    Include empty word list names in value returned by DescribeWordListSets and SCI_DESCRIBEKEYWORDSETS. Issue notepad-plus-plus#175, Pull request notepad-plus-plus#176.
    Bash: style here-doc end delimiters as SCE_SH_HERE_DELIM instead of SCE_SH_HERE_Q. Issue notepad-plus-plus#177.
    Bash: allow '$' as last character in string. Issue notepad-plus-plus#180, Pull request notepad-plus-plus#181.
    Bash: fix state after expansion. Highlight all numeric and file test operators. Don't highlight dash in long option as operator. Issue notepad-plus-plus#182, Pull request notepad-plus-plus#183.
    Bash: strict checking of special parameters ($*, $@, $$, ...) with property lexer.bash.special.parameter to specify valid parameters. Issue notepad-plus-plus#184, Pull request notepad-plus-plus#186.
    Bash: recognize keyword before redirection operators (< and >). Issue notepad-plus-plus#188, Pull request notepad-plus-plus#189.
    Errorlist: recognize Bash diagnostic messages.
    HTML: allow ASP block to terminate inside line comment. Issue notepad-plus-plus#185.
    HTML: fix folding with JSP/ASP.NET <%-- comment. Issue notepad-plus-plus#191.
    HTML: fix incremental styling of multi-line ASP.NET directive. Issue notepad-plus-plus#191.
    Matlab: improve arguments blocks. Add support for multiple arguments blocks. Prevent "arguments" from being keyword in function declaration line. Fix semicolon handling. Pull request notepad-plus-plus#179.
    Visual Prolog: add support for embedded syntax with SCE_VISUALPROLOG_EMBEDDED and SCE_VISUALPROLOG_PLACEHOLDER.
    Styling of string literals changed with no differentiation between literals with quotes and those that are prefixed with "@". Quote characters are in a separate style (SCE_VISUALPROLOG_STRING_QUOTE) to contents (SCE_VISUALPROLOG_STRING).
    SCE_VISUALPROLOG_CHARACTER, SCE_VISUALPROLOG_CHARACTER_TOO_MANY, SCE_VISUALPROLOG_CHARACTER_ESCAPE_ERROR, SCE_VISUALPROLOG_STRING_EOL_OPEN, and SCE_VISUALPROLOG_STRING_VERBATIM_SPECIAL were removed (replaced with SCE_VISUALPROLOG_UNUSED[1-5]). Pull request notepad-plus-plus#178.

Fix notepad-plus-plus#13901, fix notepad-plus-plus#13911, fix notepad-plus-plus#13943, close notepad-plus-plus#13940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.x

Development

Successfully merging this pull request may close these issues.

5 participants

@ariccio @Eldaw @MAPJe71 @donho @milipili