Skip to content

Display find progress before find in files list creation#189

Closed
pnedev wants to merge 1 commit intonotepad-plus-plus:masterfrom
pnedev:findinfiles_2
Closed

Display find progress before find in files list creation#189
pnedev wants to merge 1 commit intonotepad-plus-plus:masterfrom
pnedev:findinfiles_2

Conversation

@pnedev
Copy link
Contributor

@pnedev pnedev commented Jun 12, 2015

Displaying progress percentage is not possible during files list creation but
the currently indexed directory is shown. Cancelling search during this stage is possible as well.

Displaying progress percentage is not possible during files list creation but
the currently indexed directory is shown. Cancelling search during this stage is possible as well.
@donho
Copy link
Member

donho commented Jul 25, 2015

The advantage we get from this feature is small, to compare with the price we pay - make simple function more complex.

@donho donho closed this Jul 25, 2015
@milipili
Copy link
Contributor

Calculating a progress bar for this kind of feature is usually very time consuming. And it can be quite a disaster on network shares

Sent from my iPhone

On 25 Jul 2015, at 13:14, Don HO notifications@github.com wrote:

The advantage we get from this feature is small, to compare with the price we pay - make simple function more complex.


Reply to this email directly or view it on GitHub.

@pnedev
Copy link
Contributor Author

pnedev commented Jul 27, 2015

@donho and @milipili , I made that change because of a user request when N++ was still on SourceForge. The issue the guy had was that he was performing FindInFiles on remote machine (network share) and if there were problems with the network connection the find operation stalled without showing anything. That is because N++ was trying to make the list of the remote files to search and it was waiting for the network timeout but during this search step N++ doesn't show anything (looks like app hang to the user). Only after the list is created the actual search progress appears.

@milipili , The idea is not to show the actual remote files list creation progress - no percentage is shown during this step. During this step the progress window only gives information on the remote directory being checked for files to search (which is the only information the user actually gets about the search status) and it also gives the user a chance to cancel the find operation during this stage (which might be very time consuming if there are network problems).

This is to justify the need from this patch, It's up to you guys to decide whether it's worth merging.

@milipili
Copy link
Contributor

Ah oki. Good then.

On 27 Jul 2015, at 10:48, Pavel Nedev notifications@github.com wrote:

@donho and @milipili , I made that change because of a user request when N++ was still on SourceForge. The issue the guy had was that he was performing FindInFiles on remote machine (network share) and if there were problems with the network connection the find operation stalled without showing anything. That is because N++ was trying to make the list of the remote files to search and it was waiting for the network timeout but during this search step N++ doesn't show anything (looks like app hang to the user). Only after the list is created the actual search progress appears.

@milipili , The idea is not to show the actual remote files list creation progress - no percentage is shown during this step. During this step the progress window only gives information on the remote directory being checked for files to search (which is the only information the user actually gets about the search status) and it also gives the user a chance to cancel the find operation during this stage (which might be very time consuming if there are network problems).

This is to justify the need from this patch, It's up to you guys to decide whether it's worth merging.


Reply to this email directly or view it on GitHub.

@pnedev pnedev deleted the findinfiles_2 branch November 26, 2015 00:35
chcg added a commit to chcg/notepad-plus-plus that referenced this pull request Jul 27, 2023
update to Scinitlla Release 5.3.6 (https://www.scintilla.org/scintilla536.zip)

    Released 26 July 2023.
    Redraw calltip after showing as didn't update when size of new text exactly same as previous. Feature notepad-plus-plus#1486.
    On Win32 fix reverse arrow cursor when scaled. Bug notepad-plus-plus#2382.
    On Win32 hide cursor when typing if that system preference has been chosen. Bug notepad-plus-plus#2333.
    On Win32 and Qt, stop aligning IME candidate window to target. It is now always aligned to start of composition string. This undoes part of feature notepad-plus-plus#1300. Feature notepad-plus-plus#1488, Bug notepad-plus-plus#2391, Feature notepad-plus-plus#1300.
    On Qt, for IMEs, update micro focus when selection changes. This may move the location of IME popups to align with the caret.
    On Qt, implement replacement for IMEs which may help with actions like reconversion. This is similar to delete-surrounding on GTK.

and Lexilla Release 5.2.6 (https://www.scintilla.org/lexilla526.zip)

    Released 26 July 2023.
    Include empty word list names in value returned by DescribeWordListSets and SCI_DESCRIBEKEYWORDSETS. Issue notepad-plus-plus#175, Pull request notepad-plus-plus#176.
    Bash: style here-doc end delimiters as SCE_SH_HERE_DELIM instead of SCE_SH_HERE_Q. Issue notepad-plus-plus#177.
    Bash: allow '$' as last character in string. Issue notepad-plus-plus#180, Pull request notepad-plus-plus#181.
    Bash: fix state after expansion. Highlight all numeric and file test operators. Don't highlight dash in long option as operator. Issue notepad-plus-plus#182, Pull request notepad-plus-plus#183.
    Bash: strict checking of special parameters ($*, $@, $$, ...) with property lexer.bash.special.parameter to specify valid parameters. Issue notepad-plus-plus#184, Pull request notepad-plus-plus#186.
    Bash: recognize keyword before redirection operators (< and >). Issue notepad-plus-plus#188, Pull request notepad-plus-plus#189.
    Errorlist: recognize Bash diagnostic messages.
    HTML: allow ASP block to terminate inside line comment. Issue notepad-plus-plus#185.
    HTML: fix folding with JSP/ASP.NET <%-- comment. Issue notepad-plus-plus#191.
    HTML: fix incremental styling of multi-line ASP.NET directive. Issue notepad-plus-plus#191.
    Matlab: improve arguments blocks. Add support for multiple arguments blocks. Prevent "arguments" from being keyword in function declaration line. Fix semicolon handling. Pull request notepad-plus-plus#179.
    Visual Prolog: add support for embedded syntax with SCE_VISUALPROLOG_EMBEDDED and SCE_VISUALPROLOG_PLACEHOLDER.
    Styling of string literals changed with no differentiation between literals with quotes and those that are prefixed with "@". Quote characters are in a separate style (SCE_VISUALPROLOG_STRING_QUOTE) to contents (SCE_VISUALPROLOG_STRING).
    SCE_VISUALPROLOG_CHARACTER, SCE_VISUALPROLOG_CHARACTER_TOO_MANY, SCE_VISUALPROLOG_CHARACTER_ESCAPE_ERROR, SCE_VISUALPROLOG_STRING_EOL_OPEN, and SCE_VISUALPROLOG_STRING_VERBATIM_SPECIAL were removed (replaced with SCE_VISUALPROLOG_UNUSED[1-5]). Pull request notepad-plus-plus#178.
donho pushed a commit to donho/notepad-plus-plus that referenced this pull request Aug 1, 2023
update to Scinitlla Release 5.3.6 (https://www.scintilla.org/scintilla536.zip)

    Released 26 July 2023.
    Redraw calltip after showing as didn't update when size of new text exactly same as previous. Feature notepad-plus-plus#1486.
    On Win32 fix reverse arrow cursor when scaled. Bug notepad-plus-plus#2382.
    On Win32 hide cursor when typing if that system preference has been chosen. Bug notepad-plus-plus#2333.
    On Win32 and Qt, stop aligning IME candidate window to target. It is now always aligned to start of composition string. This undoes part of feature notepad-plus-plus#1300. Feature notepad-plus-plus#1488, Bug notepad-plus-plus#2391, Feature notepad-plus-plus#1300.
    On Qt, for IMEs, update micro focus when selection changes. This may move the location of IME popups to align with the caret.
    On Qt, implement replacement for IMEs which may help with actions like reconversion. This is similar to delete-surrounding on GTK.

and Lexilla Release 5.2.6 (https://www.scintilla.org/lexilla526.zip)

    Released 26 July 2023.
    Include empty word list names in value returned by DescribeWordListSets and SCI_DESCRIBEKEYWORDSETS. Issue notepad-plus-plus#175, Pull request notepad-plus-plus#176.
    Bash: style here-doc end delimiters as SCE_SH_HERE_DELIM instead of SCE_SH_HERE_Q. Issue notepad-plus-plus#177.
    Bash: allow '$' as last character in string. Issue notepad-plus-plus#180, Pull request notepad-plus-plus#181.
    Bash: fix state after expansion. Highlight all numeric and file test operators. Don't highlight dash in long option as operator. Issue notepad-plus-plus#182, Pull request notepad-plus-plus#183.
    Bash: strict checking of special parameters ($*, $@, $$, ...) with property lexer.bash.special.parameter to specify valid parameters. Issue notepad-plus-plus#184, Pull request notepad-plus-plus#186.
    Bash: recognize keyword before redirection operators (< and >). Issue notepad-plus-plus#188, Pull request notepad-plus-plus#189.
    Errorlist: recognize Bash diagnostic messages.
    HTML: allow ASP block to terminate inside line comment. Issue notepad-plus-plus#185.
    HTML: fix folding with JSP/ASP.NET <%-- comment. Issue notepad-plus-plus#191.
    HTML: fix incremental styling of multi-line ASP.NET directive. Issue notepad-plus-plus#191.
    Matlab: improve arguments blocks. Add support for multiple arguments blocks. Prevent "arguments" from being keyword in function declaration line. Fix semicolon handling. Pull request notepad-plus-plus#179.
    Visual Prolog: add support for embedded syntax with SCE_VISUALPROLOG_EMBEDDED and SCE_VISUALPROLOG_PLACEHOLDER.
    Styling of string literals changed with no differentiation between literals with quotes and those that are prefixed with "@". Quote characters are in a separate style (SCE_VISUALPROLOG_STRING_QUOTE) to contents (SCE_VISUALPROLOG_STRING).
    SCE_VISUALPROLOG_CHARACTER, SCE_VISUALPROLOG_CHARACTER_TOO_MANY, SCE_VISUALPROLOG_CHARACTER_ESCAPE_ERROR, SCE_VISUALPROLOG_STRING_EOL_OPEN, and SCE_VISUALPROLOG_STRING_VERBATIM_SPECIAL were removed (replaced with SCE_VISUALPROLOG_UNUSED[1-5]). Pull request notepad-plus-plus#178.

Fix notepad-plus-plus#13901, fix notepad-plus-plus#13911, fix notepad-plus-plus#13943, close notepad-plus-plus#13940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants