Add accelerator key to 'Find &All in Current Document'.#2391
Closed
dilijev wants to merge 1 commit intonotepad-plus-plus:masterfrom
Closed
Add accelerator key to 'Find &All in Current Document'.#2391dilijev wants to merge 1 commit intonotepad-plus-plus:masterfrom
dilijev wants to merge 1 commit intonotepad-plus-plus:masterfrom
Conversation
'A' does not conflict with any other accelerator key in the Find dialog. Additionally, makes the accelerator key for 'Find &All in Current Document' consistent with 'Replace &All' in the Replace dialog.
dail8859
approved these changes
Oct 4, 2016
Contributor
Author
|
I noticed this is signed off but not merged in. Is there any further action I need to take? |
SinghRajenM
reviewed
Nov 22, 2016
| PUSHBUTTON "Find All in Current Document",IDC_FINDALL_CURRENTFILE,268,80,90,21,BS_MULTILINE | ||
| PUSHBUTTON "Find &All in Current Document",IDC_FINDALL_CURRENTFILE,268,80,90,21,BS_MULTILINE | ||
| PUSHBUTTON "&Replace",IDREPLACE,268,38,90,14 | ||
| PUSHBUTTON "Replace &All",IDREPLACEALL,268,56,90,14 |
Contributor
There was a problem hiding this comment.
accelerator key is already assigned. This may be cause for regression #2595
PalashBansal
pushed a commit
to PalashBansal/notepad-plus-plus
that referenced
this pull request
Dec 3, 2016
Add accelerator key to "Find &All in Current Document" in Find dialog. Closes notepad-plus-plus#2391
anil-shrestha
pushed a commit
to anil-shrestha/notepad-plus-plus
that referenced
this pull request
Dec 7, 2016
Add accelerator key to "Find &All in Current Document" in Find dialog. Closes notepad-plus-plus#2391
iczelia
pushed a commit
to iczelia/notepad-plus-plus
that referenced
this pull request
Jan 17, 2021
Add accelerator key to "Find &All in Current Document" in Find dialog. Closes notepad-plus-plus#2391
chcg
added a commit
to chcg/notepad-plus-plus
that referenced
this pull request
Jul 27, 2023
update to Scinitlla Release 5.3.6 (https://www.scintilla.org/scintilla536.zip) Released 26 July 2023. Redraw calltip after showing as didn't update when size of new text exactly same as previous. Feature notepad-plus-plus#1486. On Win32 fix reverse arrow cursor when scaled. Bug notepad-plus-plus#2382. On Win32 hide cursor when typing if that system preference has been chosen. Bug notepad-plus-plus#2333. On Win32 and Qt, stop aligning IME candidate window to target. It is now always aligned to start of composition string. This undoes part of feature notepad-plus-plus#1300. Feature notepad-plus-plus#1488, Bug notepad-plus-plus#2391, Feature notepad-plus-plus#1300. On Qt, for IMEs, update micro focus when selection changes. This may move the location of IME popups to align with the caret. On Qt, implement replacement for IMEs which may help with actions like reconversion. This is similar to delete-surrounding on GTK. and Lexilla Release 5.2.6 (https://www.scintilla.org/lexilla526.zip) Released 26 July 2023. Include empty word list names in value returned by DescribeWordListSets and SCI_DESCRIBEKEYWORDSETS. Issue notepad-plus-plus#175, Pull request notepad-plus-plus#176. Bash: style here-doc end delimiters as SCE_SH_HERE_DELIM instead of SCE_SH_HERE_Q. Issue notepad-plus-plus#177. Bash: allow '$' as last character in string. Issue notepad-plus-plus#180, Pull request notepad-plus-plus#181. Bash: fix state after expansion. Highlight all numeric and file test operators. Don't highlight dash in long option as operator. Issue notepad-plus-plus#182, Pull request notepad-plus-plus#183. Bash: strict checking of special parameters ($*, $@, $$, ...) with property lexer.bash.special.parameter to specify valid parameters. Issue notepad-plus-plus#184, Pull request notepad-plus-plus#186. Bash: recognize keyword before redirection operators (< and >). Issue notepad-plus-plus#188, Pull request notepad-plus-plus#189. Errorlist: recognize Bash diagnostic messages. HTML: allow ASP block to terminate inside line comment. Issue notepad-plus-plus#185. HTML: fix folding with JSP/ASP.NET <%-- comment. Issue notepad-plus-plus#191. HTML: fix incremental styling of multi-line ASP.NET directive. Issue notepad-plus-plus#191. Matlab: improve arguments blocks. Add support for multiple arguments blocks. Prevent "arguments" from being keyword in function declaration line. Fix semicolon handling. Pull request notepad-plus-plus#179. Visual Prolog: add support for embedded syntax with SCE_VISUALPROLOG_EMBEDDED and SCE_VISUALPROLOG_PLACEHOLDER. Styling of string literals changed with no differentiation between literals with quotes and those that are prefixed with "@". Quote characters are in a separate style (SCE_VISUALPROLOG_STRING_QUOTE) to contents (SCE_VISUALPROLOG_STRING). SCE_VISUALPROLOG_CHARACTER, SCE_VISUALPROLOG_CHARACTER_TOO_MANY, SCE_VISUALPROLOG_CHARACTER_ESCAPE_ERROR, SCE_VISUALPROLOG_STRING_EOL_OPEN, and SCE_VISUALPROLOG_STRING_VERBATIM_SPECIAL were removed (replaced with SCE_VISUALPROLOG_UNUSED[1-5]). Pull request notepad-plus-plus#178.
donho
pushed a commit
to donho/notepad-plus-plus
that referenced
this pull request
Aug 1, 2023
update to Scinitlla Release 5.3.6 (https://www.scintilla.org/scintilla536.zip) Released 26 July 2023. Redraw calltip after showing as didn't update when size of new text exactly same as previous. Feature notepad-plus-plus#1486. On Win32 fix reverse arrow cursor when scaled. Bug notepad-plus-plus#2382. On Win32 hide cursor when typing if that system preference has been chosen. Bug notepad-plus-plus#2333. On Win32 and Qt, stop aligning IME candidate window to target. It is now always aligned to start of composition string. This undoes part of feature notepad-plus-plus#1300. Feature notepad-plus-plus#1488, Bug notepad-plus-plus#2391, Feature notepad-plus-plus#1300. On Qt, for IMEs, update micro focus when selection changes. This may move the location of IME popups to align with the caret. On Qt, implement replacement for IMEs which may help with actions like reconversion. This is similar to delete-surrounding on GTK. and Lexilla Release 5.2.6 (https://www.scintilla.org/lexilla526.zip) Released 26 July 2023. Include empty word list names in value returned by DescribeWordListSets and SCI_DESCRIBEKEYWORDSETS. Issue notepad-plus-plus#175, Pull request notepad-plus-plus#176. Bash: style here-doc end delimiters as SCE_SH_HERE_DELIM instead of SCE_SH_HERE_Q. Issue notepad-plus-plus#177. Bash: allow '$' as last character in string. Issue notepad-plus-plus#180, Pull request notepad-plus-plus#181. Bash: fix state after expansion. Highlight all numeric and file test operators. Don't highlight dash in long option as operator. Issue notepad-plus-plus#182, Pull request notepad-plus-plus#183. Bash: strict checking of special parameters ($*, $@, $$, ...) with property lexer.bash.special.parameter to specify valid parameters. Issue notepad-plus-plus#184, Pull request notepad-plus-plus#186. Bash: recognize keyword before redirection operators (< and >). Issue notepad-plus-plus#188, Pull request notepad-plus-plus#189. Errorlist: recognize Bash diagnostic messages. HTML: allow ASP block to terminate inside line comment. Issue notepad-plus-plus#185. HTML: fix folding with JSP/ASP.NET <%-- comment. Issue notepad-plus-plus#191. HTML: fix incremental styling of multi-line ASP.NET directive. Issue notepad-plus-plus#191. Matlab: improve arguments blocks. Add support for multiple arguments blocks. Prevent "arguments" from being keyword in function declaration line. Fix semicolon handling. Pull request notepad-plus-plus#179. Visual Prolog: add support for embedded syntax with SCE_VISUALPROLOG_EMBEDDED and SCE_VISUALPROLOG_PLACEHOLDER. Styling of string literals changed with no differentiation between literals with quotes and those that are prefixed with "@". Quote characters are in a separate style (SCE_VISUALPROLOG_STRING_QUOTE) to contents (SCE_VISUALPROLOG_STRING). SCE_VISUALPROLOG_CHARACTER, SCE_VISUALPROLOG_CHARACTER_TOO_MANY, SCE_VISUALPROLOG_CHARACTER_ESCAPE_ERROR, SCE_VISUALPROLOG_STRING_EOL_OPEN, and SCE_VISUALPROLOG_STRING_VERBATIM_SPECIAL were removed (replaced with SCE_VISUALPROLOG_UNUSED[1-5]). Pull request notepad-plus-plus#178. Fix notepad-plus-plus#13901, fix notepad-plus-plus#13911, fix notepad-plus-plus#13943, close notepad-plus-plus#13940
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'A' does not conflict with any other accelerator key in the Find dialog.
Additionally, makes the accelerator key for
'Find &All in Current Document' consistent with
'Replace &All' in the Replace dialog.