ScitillaComponent: Buffer: _currentStatus is used uninitialized in ctor#138
Merged
donho merged 1 commit intonotepad-plus-plus:masterfrom May 30, 2015
milipili:master
Merged
ScitillaComponent: Buffer: _currentStatus is used uninitialized in ctor#138donho merged 1 commit intonotepad-plus-plus:masterfrom milipili:master
donho merged 1 commit intonotepad-plus-plus:masterfrom
milipili:master
Conversation
The non-default constructor of the class Buffer calls the inner method `checkFileState()`, using the private variable `_currentStatus` to determine whether some checks on the file attached to the buffer are required or not. However this variable is properly initialized _after_.
donho
added a commit
that referenced
this pull request
May 30, 2015
[ScitillaComponent: Buffer: _currentStatus is used uninitialized in ctor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non-default constructor of the class Buffer calls the inner method
checkFileState(), using the private variable_currentStatusto determinewhether some checks on the file attached to the buffer are required or not.
However this variable is properly initialized after.