Merged
Conversation
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
I wonder if we can fold |
Member
Author
|
Yeah, this is temporary. We to find a better packing. |
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
…ropagation Wrap cancelTask call in try-catch to prevent exceptions from escaping killTask(). This ensures handleException() is called with the original error, allowing proper workflow termination instead of crashing the task monitor poll loop. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
- Add keep-alive mechanism to send empty submissions after 60s idle - Pass sessionId to batch submitter for API calls - Add null check in killTask when taskId not yet assigned - Update sched-client to 0.9.0-SNAPSHOT - Bump plugin version to 0.4.0 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
- Define SEQERA constant in SeqeraExecutor for reuse - Override executor name in trace record to 'seqera/aws' for cost tracking - Add unit test for getTraceRecord() method - Remove obsolete convertPriceModel test (moved to MapperUtil) Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
… [ci fast] - Add nf-seqera plugin to packing.gradle and plugins-info.txt - Fix workflow hang when batch submission fails by detecting early failure in checkIfCompleted() Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Add proper error handling to prevent thread crashes and enable graceful workflow abort on fatal errors: - Add onError callback to propagate fatal errors to session - Wrap sendTasks0 loop in try-catch to handle unexpected Throwables - Protect keep-alive calls to prevent thread crash on transient failures - Add drainAndFailPendingTasks helper to notify pending tasks on failure - Update SeqeraExecutor to pass session.abort callback Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
…xit code [ci fast] When a Seqera task fails (status=FAILED) but no exit code is available (exitStatus=MAX_VALUE), set task.error to a ProcessException with the error message from the task state, or a fallback message if not available. This aligns with the error handling pattern used in AWS Batch and Google Batch executors. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
…onfig warnings
The config validator checks @ConfigOption FIRST - if present, it treats
the field as a leaf Option and doesn't recurse into nested ConfigScope
types. This caused spurious warnings for machineRequirement nested options:
WARN: Unrecognized config option 'seqera.machineRequirement.provisioning'
WARN: Unrecognized config option 'seqera.machineRequirement.maxSpotAttempts'
Removing @ConfigOption allows the validator to recognize that
MachineRequirementOpts implements ConfigScope and properly discover
its nested @ConfigOption fields.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>
- Add disk configuration options to MachineRequirementOpts (diskType, diskThroughputMiBps, diskIops, diskEncrypted) - Extend DiskResource with cloud-specific properties (iops, throughput, encrypted, filesystem, mountPath) - Add MapperUtil.toDiskRequirement() to map disk settings to sched API - Update sched-client to 0.14.0-SNAPSHOT for DiskRequirement support - Document EBS disk configuration in executor.md and config.md - Default to gp3 volumes with 325 MiB/s throughput (Fusion recommended) Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
- Add diskAllocation config option (task/node) to MachineRequirementOpts - Update MapperUtil to map allocation and use correct volumeType API - Add validation: node allocation only supports disk size - Bump sched-client to 0.16.0-SNAPSHOT Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Validate that the container image is not empty before submitting tasks to the Seqera scheduler. The executor requires all processes to specify a container image, so this throws ProcessUnrecoverableException with a clear error message when the container is missing. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Add configurable labels that are propagated to AWS resources (ECS tasks, capacity providers, EC2 instances) for cost tracking and resource organization. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Make ExecutorOpts implement ConfigScope and remove @ConfigOption from the executor field in SeqeraConfig so nested config options are properly discovered by the config validator. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
bentsherman
reviewed
Feb 27, 2026
bentsherman
reviewed
Feb 27, 2026
bentsherman
reviewed
Feb 27, 2026
bentsherman
reviewed
Feb 27, 2026
bentsherman
approved these changes
Feb 27, 2026
Member
bentsherman
left a comment
There was a problem hiding this comment.
Looks good enough to merge, just left a few minor suggestions
Co-authored-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
--------- Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Co-authored-by: Ben Sherman <bentshermann@gmail.com>
Co-authored-by: Jon Martí <jmartifraiz@gmail.com>
Co-authored-by: Ben Sherman <bentshermann@gmail.com>
Co-authored-by: Phil Ewels <phil.ewels@seqera.io> Co-authored-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
pditommaso
added a commit
that referenced
this pull request
Mar 3, 2026
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Lorenzo Fontana <fontanalorenz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft implementation for sched poc