Report actual GCP zone from Batch status events#6855
Merged
bentsherman merged 3 commits intomasterfrom Feb 25, 2026
Merged
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
3 tasks
Collaborator
|
@pditommaso awesome! closed my PR in favor to this one (no core module changes, no extra file on GCS, doesn't depend on the script launcher, ...) |
jonmarti
approved these changes
Feb 23, 2026
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
b7943fc to
d54663e
Compare
bentsherman
approved these changes
Feb 25, 2026
pditommaso
added a commit
that referenced
this pull request
Feb 27, 2026
Co-authored-by: Jon Martí <jmartifraiz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6646
Alternative to #6854 — instead of writing a
.command.zonefile from inside the task, this approach resolves the actual execution zone by parsing Google BatchStatusEventdescriptions, which include the zone in the formatzones/<zone>/instances/<instance-id>.This avoids creating an additional bucket file and keeps all changes within the Google plugin (no core module changes).
Changes
GoogleBatchTaskHandler.groovy— On task completion,getMachineInfo()callsupdateZoneFromEvents()which fetches the task status events and parses the zone from the event description using a regex. UpdatesCloudMachineInfowith the actual zone. Uses avolatile boolean zoneUpdatedflag to ensure the API is called at most once.Design decisions
zoneUpdatedflag is set in afinallyblock, so even if the API call fails, we don't retry on everygetMachineInfo()call.command.zoneapproach, this doesn't touchTaskRunor add new bucket filesTest plan
getMachineInfo()calls