Pipeline Info - Timeline - Inconsistent verical alignment #6767#6794
Merged
bentsherman merged 3 commits intonextflow-io:masterfrom Feb 26, 2026
Merged
Pipeline Info - Timeline - Inconsistent verical alignment #6767#6794bentsherman merged 3 commits intonextflow-io:masterfrom
bentsherman merged 3 commits intonextflow-io:masterfrom
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
a32aa0f to
0ed6c0e
Compare
Contributor
Author
|
PR pending review and merge of #6792 |
35bda36 to
fe83a6b
Compare
Signed-off-by: Peter Kneale <peterkneale@gmail.com>
…o#6767) Sourced the fix from the original maintainer jiahuang/d3-timeline@8439407 The nextflow repo where this code was originally sourced from is long abandoned and archived https://github.com/nextflow-io/d3-timeline Signed-off-by: Peter Kneale <peterkneale@gmail.com>
fe83a6b to
11ed01e
Compare
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
bentsherman
approved these changes
Feb 26, 2026
Member
|
Thanks @PeterKneale for contributing! |
pditommaso
pushed a commit
that referenced
this pull request
Feb 27, 2026
pditommaso
pushed a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
Running the tests demonstrates the issue:
foo,barandbazare not vertically aligned with the timeline bars../gradlew :nextflow:test --tests "nextflow.trace.TimelineObserverTest"the fix
The nextflow repo where this code was originally sourced from is long abandoned and archived
https://github.com/nextflow-io/d3-timeline
I found the original upstream author of the library and found this commit fixing the issue.
jiahuang/d3-timeline@8439407
After applying the fix to the
.jsfile i minified the js to.min.jsas it is this file that is actually used by the templated report.Running again demonstrates the fix - you can now tell which labels apply to which bars
