Use explicit memory units for LSF executor#5217
Merged
bentsherman merged 3 commits intomasterfrom Feb 27, 2026
Merged
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Member
Author
|
@d-callan please make sure that the generated job scripts in the tests look good to you |
|
yes, its beautiful. thank you. |
5a93547 to
27345a6
Compare
b4b321e to
069653d
Compare
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
jorgee
approved these changes
Feb 27, 2026
pditommaso
pushed a commit
that referenced
this pull request
Feb 27, 2026
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
pditommaso
pushed a commit
that referenced
this pull request
Mar 3, 2026
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #5182
This PR updates the LSF executor to use explicit memory units in the job request, instead of trying to infer it from the
lsf.conf, which can lead to some weird behavior when there are multiple lsf config filesLSF supports explicit memory units with
bsub: https://www.ibm.com/docs/en/spectrum-lsf/10.1.0?topic=requirements-resource-requirement-strings#vnmbvn__title__3