Skip to content

Upgrade MjWarp and MuJoCo dependencies#715

Merged
adenzler-nvidia merged 5 commits into
newton-physics:mainfrom
adenzler-nvidia:dev/adenzler/upgrade-dependencies
Sep 3, 2025
Merged

Upgrade MjWarp and MuJoCo dependencies#715
adenzler-nvidia merged 5 commits into
newton-physics:mainfrom
adenzler-nvidia:dev/adenzler/upgrade-dependencies

Conversation

@adenzler-nvidia

@adenzler-nvidia adenzler-nvidia commented Sep 3, 2025

Copy link
Copy Markdown
Member

Before your PR is "Ready for review"

  • Necessary tests have been added and new examples are tested (see newton/tests/test_examples.py)
  • Documentation is up-to-date
  • Code passes formatting and linting checks with pre-commit run -a

Summary by CodeRabbit

  • Chores
    • Updated benchmark environment to use newer pre-release builds of simulation dependencies, aligning versions for installation.
    • Improves reliability and compatibility of performance/benchmark setup.
    • No functional or API changes; application behavior remains unchanged.

Signed-off-by: Alain Denzler <adenzler@nvidia.com>
Signed-off-by: Alain Denzler <adenzler@nvidia.com>
@coderabbitai

coderabbitai Bot commented Sep 3, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Updated dependency pins in asv.conf.json: bumped MuJoCo pre-release version and updated the pinned mujoco_warp commit in install commands. No other changes.

Changes

Cohort / File(s) Summary of Changes
ASV config dependency pins
asv.conf.json
Updated install_command entries: MuJoCo from 3.3.6.dev7978708833.3.6.dev802089588; mujoco_warp commit from f19ac605807eba8140ebac19b0ba7cece638c21dca6e29285b856cc06bd39127aafadbf4dd56f944. No other lines changed.

Sequence Diagram(s)

(omitted — changes are simple dependency pin updates without control-flow or feature modifications)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • shi-eric
  • preist-nvidia
  • eric-heiden

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1fed71a and 581a5b5.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • asv.conf.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • asv.conf.json
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Run GPU Unit Tests on AWS EC2 (Pull Request)
  • GitHub Check: Run GPU Benchmarks (Pull Request)
  • GitHub Check: run-newton-tests / newton-unittests (windows-latest)
  • GitHub Check: run-newton-tests / newton-unittests (ubuntu-latest)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Comment thread uv.lock
Comment thread uv.lock
@adenzler-nvidia adenzler-nvidia enabled auto-merge (squash) September 3, 2025 13:58
Signed-off-by: Alain Denzler <adenzler@nvidia.com>
Signed-off-by: Alain Denzler <adenzler@nvidia.com>
@adenzler-nvidia adenzler-nvidia merged commit 0e8ee91 into newton-physics:main Sep 3, 2025
11 of 12 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Sep 28, 2025
4 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Oct 6, 2025
3 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Dec 11, 2025
eric-heiden pushed a commit to eric-heiden/newton that referenced this pull request Jan 28, 2026
Signed-off-by: Alain Denzler <adenzler@nvidia.com>
mmacklin pushed a commit to mmacklin/newton that referenced this pull request Apr 7, 2026
Signed-off-by: Alain Denzler <adenzler@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants