Update mujoco_warp dependency#692
Conversation
📝 WalkthroughWalkthroughUpdated asv.conf.json to change the pinned Git commit for the mujoco_warp install_command from baeb10e to f19ac60. No other changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
asv.conf.json (1)
22-22: Option: avoid resolver churn by skipping deps for the git installSince warp-lang and mujoco are pre-installed/pinned just above, consider installing mujoco_warp without re-resolving dependencies to speed up ASV env creation and reduce accidental downgrades.
Apply:
- "python -m pip install git+https://github.com/google-deepmind/mujoco_warp@f19ac605807eba8140ebac19b0ba7cece638c21d", + "python -m pip install --no-deps git+https://github.com/google-deepmind/mujoco_warp@f19ac605807eba8140ebac19b0ba7cece638c21d",
📜 Review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
asv.conf.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: shi-eric
PR: newton-physics/newton#521
File: newton/examples/example_cloth_hanging.py:36-36
Timestamp: 2025-08-12T05:17:34.423Z
Learning: The Newton migration guide (docs/migration.rst) is specifically for documenting how to migrate existing warp.sim functionality to Newton equivalents. New Newton-only features that didn't exist in warp.sim do not need migration documentation.
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Run GPU Unit Tests on AWS EC2 (Pull Request)
- GitHub Check: Run GPU Benchmarks (Pull Request)
- GitHub Check: run-newton-tests / newton-unittests (windows-latest)
- GitHub Check: run-newton-tests / newton-unittests (ubuntu-latest)
🔇 Additional comments (4)
asv.conf.json (4)
22-22: LGTM: pinned mujoco_warp to an immutable commitBumping to a specific SHA improves reproducibility for ASV envs. No issues spotted with the pip VCS URL syntax.
22-24: No migration docs update needed for the mujoco_warp bump
This change only updates the pip source for mujoco_warp and does not affect any warp.sim→Newton migration steps.
22-22: Commit and dependency check passed
Commit f19ac60 exists (pyproject.toml fetched) and lists “mujoco” and “warp-lang” without version bounds, so ASV-specified pins remain authoritative (raw.githubusercontent.com)
17-24: Verify GPU wheel compatibility on CI
Ensure the CI/benchmark hosts have CUDA 12.8 drivers, access to the specified PyPI indexes, and can install and import torch 2.7.1+cu128, warp-lang 1.9.0.dev20250825, and mujoco 3.3.6.dev797870883.
Description
Updated mujoco_warp dependency
Newton Migration Guide
Please ensure the migration guide for warp.sim users is up-to-date with the changes made in this PR.
docs/migration.rstis up-to dateBefore your PR is "Ready for review"
newton/tests/test_examples.py)pre-commit run -aSummary by CodeRabbit