Update MjWarp and MuJoCo dependency#618
Conversation
Signed-off-by: Alain Denzler <adenzler@nvidia.com>
📝 WalkthroughWalkthroughUpdates asv.conf.json install_command pins: mujoco pre-release bumped from 3.3.6.dev793087071 to 3.3.6.dev797870883; mujoco_warp commit updated from 6ee6a67 to baeb10e. No other changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
asv.conf.json(1 hunks)
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Run GPU Unit Tests on AWS EC2 (Pull Request)
- GitHub Check: Run GPU Benchmarks (Pull Request)
- GitHub Check: run-newton-tests / newton-unittests (windows-latest)
- GitHub Check: run-newton-tests / newton-unittests (ubuntu-latest)
🔇 Additional comments (1)
asv.conf.json (1)
20-20: Verify MuJoCo dev-build wheels and mujoco_warp compatibilityWe’ve confirmed that the 3.3.6.dev797870883 wheel is published under the
/mujoco/subdirectory on py.mujoco.org and can be downloaded via pip. Before merging, please verify:
- All CI targets (Linux x86_64, Linux aarch64) and every CPython version you benchmark have a matching wheel under the simple index at https://py.mujoco.org/mujoco/simple/mujoco/
- No breaking API/ABI changes in this dev build affect mujoco_warp at its pinned commit
Optional: for reproducible ASV baselines, consider pinning to the latest tagged/stable MuJoCo release in CI and reserving dev builds for local experiments.
You can run this check (no installs) to confirm wheel availability:
#!/usr/bin/env bash set -euo pipefail # 1) Confirm dev wheel is listed under /mujoco/simple/mujoco/ curl -fsSL https://py.mujoco.org/mujoco/simple/mujoco/ \ | rg -q '3\.3\.6\.dev797870883' \ && echo "MuJoCo 3.3.6.dev797870883: INDEXED" \ || { echo "MuJoCo 3.3.6.dev797870883: MISSING"; exit 1; } # 2) Dry-run download via the correct find-links URL python -m pip download --only-binary=:all: \ -d /tmp/mj_wheels -f https://py.mujoco.org/mujoco/ \ "mujoco==3.3.6.dev797870883" # 3) Inspect downloaded files (ensure you see wheels for each arch/CPython) ls -lh /tmp/mj_wheelsPlease confirm all runners and versions pass, and that mujoco_warp works as expected against this dev build.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Alain Denzler <adenzler@nvidia.com>
Signed-off-by: Alain Denzler <adenzler@nvidia.com>
Summary by CodeRabbit