Update various project dependencies#495
Conversation
📝 WalkthroughWalkthroughThis update revises dependency versions and commit hashes in the ASV benchmarking configuration and reorganizes the package index and development dependencies in the project’s configuration. No changes are made to source code or exported entities; all modifications are limited to configuration files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yml 📥 CommitsReviewing files that changed from the base of the PR and between b3c79af81a2caea68c412460bd1b4f2d24be2577 and a1af376. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
pyproject.toml (1)
45-45: Pin or range-bound the newcoacddev dependency.
coacdis added without an upper bound. While that is acceptable for a loose dev stack, un-pinned “≥” specs have broken CI in the past when upstream releases a breaking change. Consider~=1.0.7or an upper cap to keep the dev environment reproducible.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 036222c and b3c79af81a2caea68c412460bd1b4f2d24be2577.
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
asv.conf.json(1 hunks)pyproject.toml(4 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: the nvidia pypi index at https://pypi.nvidia.com/ does not follow the standard pypi simple index for...
Learnt from: shi-eric
PR: newton-physics/newton#416
File: asv.conf.json:19-19
Timestamp: 2025-07-15T15:48:18.421Z
Learning: The NVIDIA PyPI index at https://pypi.nvidia.com/ does not follow the standard PyPI simple index format. While packages can be installed via pip using the --index-url flag, the simple index listings (like /simple/package-name/) return XML errors. Packages are accessible via direct URLs but verification should be done using direct URL checks rather than simple index listings or pip index commands.
Applied to files:
pyproject.toml
📚 Learning: the nvidia pypi index at https://pypi.nvidia.com/ may not always show packages in the simple index l...
Learnt from: shi-eric
PR: newton-physics/newton#416
File: asv.conf.json:19-19
Timestamp: 2025-07-15T15:48:18.421Z
Learning: The NVIDIA PyPI index at https://pypi.nvidia.com/ may not always show packages in the simple index listing format that can be easily grepped, but packages can still be available via direct URLs. When verifying NVIDIA PyPI packages, it's better to check the direct URL or use pip index commands rather than relying solely on simple index listings.
Applied to files:
pyproject.toml
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Run GPU Benchmarks (Pull Request)
- GitHub Check: Run GPU Unit Tests on AWS EC2 (Pull Request)
- GitHub Check: run-newton-tests / newton-unittests (windows-latest)
🔇 Additional comments (2)
pyproject.toml (2)
88-91: Add/simplesuffix to the PyTorch CUDA index for consistency.
https://download.pytorch.org/whl/cu128works, but unlike the canonical PyPI index it is not a “simple” endpoint. Some resolvers append/simple/automatically and will 404. Prefer the documented simple endpoint (…/cu128/simple) or verify that uv never appends the extra segment.
124-128: Confirm the Mujoco index is a proper PEP 503 simple repository.
https://py.mujoco.orglooks like a plain files index rather than a PEP 503 simple repo. If uv/pip ever trieshttps://py.mujoco.org/simple/, installation will fail.Run a quick check or switch to
-f https://py.mujoco.org(find-links) consistently across bothpyproject.tomlandasv.conf.json.
Signed-off-by: Eric Shi <ershi@nvidia.com>
b3c79af to
a1af376
Compare
Signed-off-by: Eric Shi <ershi@nvidia.com>
Signed-off-by: Eric Shi <ershi@nvidia.com>
Description
Mass-update of dependencies, remove Artifactory index, adding missing
coacdoptional dep (noticed by @apradhana).Newton Migration Guide
Please ensure the migration guide for warp.sim users is up-to-date with the changes made in this MR.
docs/migration.rstis up-to dateBefore your PR is "Ready for review"
newton/tests/test_examples.py)pre-commit run -aSummary by CodeRabbit